-
-
Notifications
You must be signed in to change notification settings - Fork 35
Draft
Conversation
gagbo
commented
Jan 27, 2023
Collaborator
I'll check this code when I have time, but looking at the title, it looks like I'd rather wait for #50 (and/or the associated RFC) instead of trying to create and enforce our own security model around crates privacy
davidv1992
commented
Feb 2, 2023
Author
Apologies, didn't realize #50 did the same as this PR. This one is also build on the same Cargo RFC. Feel free to close this if a version based on the refactor isn't needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures people need to be logged in for all operations on the registry, ensuring that private code is not leaked. I intend to make a better implementation of this once #57 lands.