Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: detect if project uses sail #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calebdw wants to merge 1 commit into laravel:main
base: main
Choose a base branch
Loading
from calebdw:calebdw/push-mxkkxwromrzx

Conversation

Copy link
Contributor

@calebdw calebdw commented Aug 13, 2025

Hello!

This detects if the project uses sail and automatically updates the mcp commands

Thanks!

Liamso, nikspyratos, gigerIT, and avosalmon reacted with thumbs up emoji
@calebdw calebdw force-pushed the calebdw/push-mxkkxwromrzx branch 2 times, most recently from 822fe74 to afec83a Compare August 13, 2025 20:00
Copy link

I feel like we also need to update some other stubs or generated guidelines.

Ex. The guidelines being generated within CLAUDE.md - these examples would fail without appending "sail" in front

### Vite Error
- If you receive an "Illuminate\Foundation\ViteException: Unable to locate file in Vite manifest" error, you can run `npm run build` or ask the user to run `npm run dev` or `composer run dev`.

Copy link
Contributor Author

calebdw commented Aug 13, 2025

Sure, but that's a slightly separate concern. The main thing is getting the mcp server to be utilized in the first place

Liamso reacted with heart emoji

Copy link

Liamso commented Aug 13, 2025

+1 - surprised this wasn't picked up during dev. Thanks for the PR.

Might be best to allow an override in the user's .env - some projects will have sail installed but unused.

nikspyratos reacted with thumbs up emoji

Copy link

gigerIT commented Aug 14, 2025

Can we also add Sail support for the guidelines files in this PR?
Currently, it generates them with:

php artisan test

Example:

=== tests rules ===
## Test Enforcement
- Every change must be programmatically tested. Write a new test or update an existing test, then run the affected tests to make sure they pass.
- Run the minimum number of tests needed to ensure code quality and speed. Use `php artisan test` with a specific filename or filter.
</laravel-boost-guidelines>

Instead of:
sail test

Copy link

nikspyratos commented Aug 14, 2025
edited
Loading

I think Sail docs can be split out into another PR, but would it not be better to instruct the agent to just use sail artisan for all artisan commands instead of individual instructions in this scenario?

Copy link

gigerIT commented Aug 14, 2025

I think Sail docs can be split out into another PR, but would it not be better to instruct the agent to just use sail artisan for all artisan commands instead of individual instructions in this scenario?

Agreed, then it could just be a variable, either php or sail, used as the base for all generated commands in the docs.

Copy link
Member

Should we add configuration here to support Laravel Sail?
I have several projects where I've installed Sail, but I end up running composer run dev locally instead. This is a very opinionated choice.
If we add Sail support. we can add it to installation options, we'd need to ask users whether they're using Sail or not. Simply detecting the package installation and auto-configuring based on that could lead to incorrect installations.

Curios to know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /