Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix PHPStorm using absolute paths #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleyhindle merged 13 commits into main from fix-phpstorm-on-windows-v1
Aug 14, 2025
Merged

Conversation

Copy link
Collaborator

@ashleyhindle ashleyhindle commented Aug 14, 2025
edited
Loading

PHPStorm is the only editor that requires absolute paths in its config. Right now we don't pass an absolute path to 'php' so people are having issues using Boost in PHPStorm.

Caveats

Absolute paths make it impossible to commit the resulting file for use within a team. We might need to update docs to say "Add to .gitignore and each dev manually adds until it's improved, sorry!" 😬

@ashleyhindle ashleyhindle changed the title (削除) Fix PHPStorm on Windows v1 (削除ここまで) (追記) Fix PHPStorm using absolute paths (追記ここまで) Aug 14, 2025
@ashleyhindle ashleyhindle marked this pull request as ready for review August 14, 2025 12:42
Copy link

cord commented Aug 14, 2025

on macOs whereis php returns /Users/cord/Library/Application Support/Herd/bin//php as absolute path to php.

Looks like the blank in the path is causing issues?

Copy link
Collaborator Author

on macOs whereis php returns /Users/cord/Library/Application Support/Herd/bin//php as absolute path to php.

Looks like the blank in the path is causing issues?

Ah yes, PHPStorm also can't handle spaces even if you escape them 🤔 Good point

Copy link
Contributor

calebdw commented Aug 14, 2025

@ashleyhindle, please review #83 before this is merged as this will break how that detects and switches between php and sail as the primary command---just something to think about as you architect this

ashleyhindle reacted with eyes emoji

ashleyhindle and others added 2 commits August 14, 2025 15:15
refactor: streamline path resolution and simplify the MCP client interface
@ashleyhindle ashleyhindle merged commit 5dce9e9 into main Aug 14, 2025
10 checks passed
@ashleyhindle ashleyhindle deleted the fix-phpstorm-on-windows-v1 branch August 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushpak1300 pushpak1300 pushpak1300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /