-
Notifications
You must be signed in to change notification settings - Fork 269
Balanced parentheses problem added #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do look into the required changes. Thanks for the PR 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a switch case here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think switch case isn't needed here since we have to check two variables char & prev here. can i use ternary operator instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this
return !string.split('').reduce((prev, char) => { const result = prev < 0 ? prev : char === '(' ? ++prev : char === ')' ? --prev : prev; return result; }, 0);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above snippet is not readable enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, if else pattern will be fine right ? switch case will add more code since we have to check cases for prev & char.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about an arrow function here?
Uh oh!
There was an error while loading. Please reload this page.
Issue no : #166
Solving balanced paratheses problem using reduce() method in ES6.