Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

reworked 'format' to default to annotation except when configured for assertion #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregsdennis wants to merge 1 commit into master from issue-1020-format-is-always-annotation

Conversation

Copy link
Member

@gregsdennis gregsdennis commented Nov 19, 2020
edited
Loading

There is also this in the "Custom format attributes" section below the edits:

An implementation MUST NOT fail validation or cease processing due to an unknown format attribute.

What is an implementation to do when an unknown format is encountered other than fail?


Closes #1026.
Closes #1027.

karenetheridge reacted with eyes emoji
@gregsdennis gregsdennis changed the title (削除) resolves #1020 - reworked 'format' to default to annotation except when configured for assertion (削除ここまで) (追記) reworked 'format' to default to annotation except when configured for assertion (追記ここまで) Nov 19, 2020
Copy link
Member

I'm not in favour of this change at this time.
I have explained why here: #1020 (comment)

karenetheridge reacted with thumbs up emoji

Copy link
Member Author

Alternative change in #1026.

@gregsdennis gregsdennis removed the request for review from handrews November 21, 2020 11:46
@gregsdennis gregsdennis deleted the issue-1020-format-is-always-annotation branch September 20, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Relequestual Relequestual Awaiting requested review from Relequestual

@karenetheridge karenetheridge Awaiting requested review from karenetheridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format should not change behavior based on its vocabulary value

AltStyle によって変換されたページ (->オリジナル) /