-
-
Notifications
You must be signed in to change notification settings - Fork 348
reworked 'format' to default to annotation except when configured for assertion #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...en configured for assertion
@gregsdennis
gregsdennis
requested review from
handrews,
Relequestual and
karenetheridge
November 19, 2020 06:07
@gregsdennis
gregsdennis
changed the title
(削除) resolves #1020 - reworked 'format' to default to annotation except when configured for assertion (削除ここまで)
(追記) reworked 'format' to default to annotation except when configured for assertion (追記ここまで)
Nov 19, 2020
I'm not in favour of this change at this time.
I have explained why here: #1020 (comment)
Alternative change in #1026.
@gregsdennis
gregsdennis
deleted the
issue-1020-format-is-always-annotation
branch
September 20, 2023 21:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There is also this in the "Custom format attributes" section below the edits:
What is an implementation to do when an unknown format is encountered other than fail?
Closes #1026.
Closes #1027.