Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

added language to explicitly specify behavior when a vocab is known #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Relequestual merged 3 commits into master from issue-1019-known-vocabs-are-always-processed
Nov 22, 2020

Conversation

Copy link
Member

@gregsdennis gregsdennis commented Nov 19, 2020

No description provided.

karenetheridge reacted with eyes emoji
@gregsdennis gregsdennis changed the title (削除) resolves #1019 - added language to explicitly specify behavior when a vocab is known (削除ここまで) (追記) added language to explicitly specify behavior when a vocab is known (追記ここまで) Nov 19, 2020
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single change suggestion. Semantics! 🙄

Otherwise, this PR is good to go.
Thanks for your effort in making it happen =]

 

Co-authored-by: Ben Hutton <relequestual@gmail.com>
Copy link
Member Author

merge when ready

Copy link
Member

Is a footnote necessary, to indicate that the handling for the format vocabulary is special-cased?

Copy link
Member Author

gregsdennis commented Nov 20, 2020 •
edited
Loading

@karenetheridge no. Please see #1023 / #1026 for changes to format, which remove the special-case treatment. This change is purely for vocabularies.

@Relequestual Relequestual merged commit e6bead3 into master Nov 22, 2020
@handrews handrews deleted the issue-1019-known-vocabs-are-always-processed branch October 17, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenetheridge karenetheridge karenetheridge approved these changes

@Relequestual Relequestual Relequestual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$vocabulary:{<vocab>:false} when a vocab is recognized is not defined

AltStyle によって変換されたページ (->オリジナル) /