Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added tasks 374, 378, 380 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javadev merged 2 commits into javadev:main from ThanhNIT:tasks-374-378-380
Dec 17, 2021
Merged

Added tasks 374, 378, 380 #135

javadev merged 2 commits into javadev:main from ThanhNIT:tasks-374-378-380
Dec 17, 2021

Conversation

Copy link
Contributor

@ThanhNIT ThanhNIT commented Dec 17, 2021

No description provided.

}
}

/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not use javadoc comments to avoid reformatting block.

ThanhNIT reacted with thumbs up emoji

**Example 1:**

**Input** \["RandomizedSet", "insert", "remove", "insert", "getRandom", "remove", "insert", "getRandom"\] \[\[\], \[1\], \[2\], \[2\], \[\], \[1\], \[2\], \[\]\]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like multiline block.

ThanhNIT reacted with thumbs up emoji

class RandomizedSetTest {
@Test
void RandomizedSet() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name method from non capital letter.

ThanhNIT reacted with thumbs up emoji

// #Easy #Binary_Search #Interactive

/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not use javadoc comments.

ThanhNIT reacted with thumbs up emoji
return true;
}

/** Removes a value from the set. Returns true if the set contained the specified element. */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a simple comment, not javadoc.

ThanhNIT reacted with thumbs up emoji

/** Initialize your data structure here. */
public RandomizedSet() {
this.rand = new Random();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThanhNIT reacted with thumbs up emoji
Copy link

Copy link
Owner

javadev commented Dec 17, 2021

👍

@javadev javadev merged commit 909f90b into javadev:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javadev javadev javadev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /