-
-
Notifications
You must be signed in to change notification settings - Fork 406
Add Code Action for adding a module to your project's cabal file #4617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61bf7ee to
16bef12
Compare
16bef12 to
234cb09
Compare
@VeryMilkyJoe please upgrade to the latest commit of cabal-add, Bodigrim/cabal-add@d831980. Once you confirm that it works well, I'll make a release.
c40661e to
56144e4
Compare
@VeryMilkyJoe please upgrade to the latest commit of
cabal-add, Bodigrim/cabal-add@d831980. Once you confirm that it works well, I'll make a release.
Done and all tests that matter are green :)
56144e4 to
6a950f1
Compare
c93ce2a to
47a6dca
Compare
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Command.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Types.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Types.hs
Outdated
Show resolved
Hide resolved
In my opinion, this is in a merge ready state, unless anyone wants to look over it again 🙃 @fendor?
c508085 to
ec0b496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, final cleanup round
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Command.hs
Outdated
Show resolved
Hide resolved
ec0b496 to
b2cfba6
Compare
For diagnostics complaining about the current module being unknown, we now offer code actions to add the module to any possible field in the responsible cabal file. Additionally, refactor the cabal-plugin into smaller modules and refactor the add-package feature to have some shared functions to be used for both add-package and add-module.
b2cfba6 to
5876af4
Compare
Uh oh!
There was an error while loading. Please reload this page.
For diagnostics complaining about the current haskell module being unknown, we now offer all possible code actions to add the module to a field in the responsible cabal file.
Additionally, this PR refactors the cabal-plugin into smaller modules and also refactors the add-package feature to have some shared functions to be used for both add-package and add-module.
Thank you to @Bodigrim for the changes in
cabal-addthat made it possible to implement this feature without a huge amount of pain!Screencast.From.2025年06月07日.17-49-54.mp4