Commit c93ce2a

committed

Add Code Action for adding a module to the cabal file

For diagnostics complaining about the current module being unknown, we now offer code actions to add the module to any possible field in the responsible cabal file. Additionally, refactor the cabal-plugin into smaller modules and refactor the add-package feature to have some shared functions to be used for both add-package and add-module.

1 parent 8cac5fb commit c93ce2aCopy full SHA for c93ce2a

File tree

20 files changed

+1345

-691

lines changed

cabal.project
haskell-language-server.cabal
plugins/hls-cabal-plugin
- src/Ide/Plugin
  - Cabal.hs
  - Cabal
    - CabalAdd.hs
    - CabalAdd
    - Files.hs
    - OfInterest.hs
    - Orphans.hs
    - Parse.hs
    - Rules.hs
- test
  - CabalAdd.hs
  - Main.hs
  - testdata/cabal-add-module/library
stack-lts22.yaml
stack.yaml

20 files changed

+1345

-691

lines changed

`‎cabal.project`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ packages:`
`8`	`8`	`./hls-test-utils`
`9`	`9`
`10`	`10`
`11`		`-index-state: 2025-06-16T09:44:13Z`
	`11`	`+index-state: 2025-07-08T09:44:13Z`
`12`	`12`
`13`	`13`	`tests: True`
`14`	`14`	`test-show-details: direct`

`‎haskell-language-server.cabal`

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -254,8 +254,13 @@ library hls-cabal-plugin`
`254`	`254`	`Ide.Plugin.Cabal.Completion.Types`
`255`	`255`	`Ide.Plugin.Cabal.Definition`
`256`	`256`	`Ide.Plugin.Cabal.FieldSuggest`
	`257`	`+ Ide.Plugin.Cabal.Files`
	`258`	`+ Ide.Plugin.Cabal.OfInterest`
`257`	`259`	`Ide.Plugin.Cabal.LicenseSuggest`
`258`		`- Ide.Plugin.Cabal.CabalAdd`
	`260`	`+ Ide.Plugin.Cabal.Rules`
	`261`	`+ Ide.Plugin.Cabal.CabalAdd.Command`
	`262`	`+ Ide.Plugin.Cabal.CabalAdd.CodeAction`
	`263`	`+ Ide.Plugin.Cabal.CabalAdd.Types`
`259`	`264`	`Ide.Plugin.Cabal.Orphans`
`260`	`265`	`Ide.Plugin.Cabal.Outline`
`261`	`266`	`Ide.Plugin.Cabal.Parse`
`@@ -276,14 +281,14 @@ library hls-cabal-plugin`
`276`	`281`	`, lens`
`277`	`282`	`, lsp ^>=2.7`
`278`	`283`	`, lsp-types ^>=2.3`
	`284`	`+ , mtl`
`279`	`285`	`, regex-tdfa ^>=1.3.1`
`280`	`286`	`, text`
`281`	`287`	`, text-rope`
`282`	`288`	`, transformers`
`283`	`289`	`, unordered-containers >=0.2.10.0`
`284`	`290`	`, containers`
`285`		`- , cabal-add`
`286`		`- , process`
	`291`	`+ , cabal-add ^>=0.2`
`287`	`292`	`, aeson`
`288`	`293`	`, Cabal`
`289`	`294`	`, pretty`
`@@ -315,7 +320,6 @@ test-suite hls-cabal-plugin-tests`
`315`	`320`	`, lens`
`316`	`321`	`, lsp-types`
`317`	`322`	`, text`
`318`		`- , hls-plugin-api`
`319`	`323`
`320`	`324`	`-----------------------------`
`321`	`325`	`-- class plugin`

`‎plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal.hs`

Lines changed: 164 additions & 325 deletions

Large diffs are not rendered by default.

`‎plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd.hs`

Lines changed: 0 additions & 326 deletions

This file was deleted.

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit c93ce2a

File tree

20 files changed

20 files changed

`‎cabal.project`

`‎haskell-language-server.cabal`

`‎plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal.hs`

`‎plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd.hs`

0 commit comments