-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix cargo check warnings #6102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix cargo check warnings #6102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes all 16 cargo check warnings across the codebase: **Cargo.toml fixes:** - Remove invalid `doc = false` key from git dependency **Dead code warnings:** - Add #[allow(dead_code)] to reference implementations and test utilities - PoI struct and helper functions (proof_of_indexing/reference.rs) - AscSubgraphEntityOp enum (runtime/wasm) - CopyVid struct (store/postgres) **Lifetime syntax warnings:** - Add explicit '_ lifetime parameters to fix confusing syntax - Fix 11 lifetime warnings across store, runtime, and utility modules All tests pass and cargo check now produces zero warnings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
@fubhy
fubhy
force-pushed
the
fix-cargo-check-warnings
branch
from
August 14, 2025 16:36
58e107e to
a742b35
Compare
lutter
lutter
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of allow(dead_code) that should really be addressed by moving code around. I can do that once this PR is committed.
/// well-implemented (without conflicting sequence numbers, or other oddities).
/// It's just way easier to check that this works, and serves as a kind of
/// documentation as a side-benefit.
#[allow(dead_code)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved into the tests module in graph/src/components/subgraph/proof_of_indexing/mod.rs.
lutter
pushed a commit
that referenced
this pull request
Sep 16, 2025
Fixes all 16 cargo check warnings across the codebase: **Cargo.toml fixes:** - Remove invalid `doc = false` key from git dependency **Dead code warnings:** - Add #[allow(dead_code)] to reference implementations and test utilities - PoI struct and helper functions (proof_of_indexing/reference.rs) - AscSubgraphEntityOp enum (runtime/wasm) - CopyVid struct (store/postgres) **Lifetime syntax warnings:** - Add explicit '_ lifetime parameters to fix confusing syntax - Fix 11 lifetime warnings across store, runtime, and utility modules All tests pass and cargo check now produces zero warnings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.