Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit a5d8811

Browse files
fubhyclaude
authored andcommitted
all: fix all cargo check warnings (#6102)
Fixes all 16 cargo check warnings across the codebase: **Cargo.toml fixes:** - Remove invalid `doc = false` key from git dependency **Dead code warnings:** - Add #[allow(dead_code)] to reference implementations and test utilities - PoI struct and helper functions (proof_of_indexing/reference.rs) - AscSubgraphEntityOp enum (runtime/wasm) - CopyVid struct (store/postgres) **Lifetime syntax warnings:** - Add explicit '_ lifetime parameters to fix confusing syntax - Fix 11 lifetime warnings across store, runtime, and utility modules All tests pass and cargo check now produces zero warnings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent 0e192f8 commit a5d8811

File tree

10 files changed

+16
-11
lines changed

10 files changed

+16
-11
lines changed

‎graph/Cargo.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ sqlparser = { workspace = true }
6161
# stable-hash_legacy = { version = "0.3.3", package = "stable-hash" }
6262
# stable-hash = { version = "0.4.2" }
6363
stable-hash = { git = "https://github.com/graphprotocol/stable-hash", branch = "main" }
64-
stable-hash_legacy = { git = "https://github.com/graphprotocol/stable-hash", branch = "old", package = "stable-hash", doc = false }
64+
stable-hash_legacy = { git = "https://github.com/graphprotocol/stable-hash", branch = "old", package = "stable-hash" }
6565
strum_macros = "0.27.1"
6666
slog-async = "2.5.0"
6767
slog-envlogger = "2.1.0"

‎graph/src/components/store/write.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ impl EntityModification {
145145

146146
/// Return the details of the write if `self` is a write operation for a
147147
/// new or an existing entity
148-
fn as_write(&self) -> Option<EntityWrite> {
148+
fn as_write(&self) -> Option<EntityWrite<'_>> {
149149
EntityWrite::try_from(self).ok()
150150
}
151151

@@ -823,7 +823,7 @@ impl Batch {
823823
&self,
824824
entity_type: &EntityType,
825825
at: BlockNumber,
826-
) -> impl Iterator<Item = EntityOp> {
826+
) -> impl Iterator<Item = EntityOp<'_>> {
827827
self.mods
828828
.group(entity_type)
829829
.map(|group| group.effective_ops(at))

‎graph/src/components/subgraph/proof_of_indexing/reference.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,20 @@ use web3::types::{Address, H256};
99
/// well-implemented (without conflicting sequence numbers, or other oddities).
1010
/// It's just way easier to check that this works, and serves as a kind of
1111
/// documentation as a side-benefit.
12+
#[allow(dead_code)]
1213
pub struct PoI<'a> {
1314
pub causality_regions: HashMap<String, PoICausalityRegion<'a>>,
1415
pub subgraph_id: DeploymentHash,
1516
pub block_hash: H256,
1617
pub indexer: Option<Address>,
1718
}
1819

20+
#[allow(dead_code)]
1921
fn h256_as_bytes(val: &H256) -> AsBytes<&[u8]> {
2022
AsBytes(val.as_bytes())
2123
}
2224

25+
#[allow(dead_code)]
2326
fn indexer_opt_as_bytes(val: &Option<Address>) -> Option<AsBytes<&[u8]>> {
2427
val.as_ref().map(|v| AsBytes(v.as_bytes()))
2528
}

‎graph/src/util/timed_rw_lock.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ impl<T> TimedRwLock<T> {
2020
}
2121
}
2222

23-
pub fn write(&self, logger: &Logger) -> parking_lot::RwLockWriteGuard<T> {
23+
pub fn write(&self, logger: &Logger) -> parking_lot::RwLockWriteGuard<'_,T> {
2424
loop {
2525
let mut elapsed = Duration::from_secs(0);
2626
match self.lock.try_write_for(self.log_threshold) {
@@ -36,11 +36,11 @@ impl<T> TimedRwLock<T> {
3636
}
3737
}
3838

39-
pub fn try_read(&self) -> Option<parking_lot::RwLockReadGuard<T>> {
39+
pub fn try_read(&self) -> Option<parking_lot::RwLockReadGuard<'_,T>> {
4040
self.lock.try_read()
4141
}
4242

43-
pub fn read(&self, logger: &Logger) -> parking_lot::RwLockReadGuard<T> {
43+
pub fn read(&self, logger: &Logger) -> parking_lot::RwLockReadGuard<'_,T> {
4444
loop {
4545
let mut elapsed = Duration::from_secs(0);
4646
match self.lock.try_read_for(self.log_threshold) {
@@ -73,7 +73,7 @@ impl<T> TimedMutex<T> {
7373
}
7474
}
7575

76-
pub fn lock(&self, logger: &Logger) -> parking_lot::MutexGuard<T> {
76+
pub fn lock(&self, logger: &Logger) -> parking_lot::MutexGuard<'_,T> {
7777
let start = Instant::now();
7878
let guard = self.lock.lock();
7979
let elapsed = start.elapsed();

‎runtime/wasm/src/module/instance.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ impl WasmInstance {
141141
self.store.into_data()
142142
}
143143

144-
pub(crate) fn instance_ctx(&mut self) -> WasmInstanceContext {
144+
pub(crate) fn instance_ctx(&mut self) -> WasmInstanceContext<'_> {
145145
WasmInstanceContext::new(&mut self.store)
146146
}
147147

‎runtime/wasm/src/to_from/external.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,7 @@ where
466466
}
467467

468468
#[derive(Debug, Clone, Eq, PartialEq, AscType)]
469+
#[allow(dead_code)]
469470
pub enum AscSubgraphEntityOp {
470471
Create,
471472
Modify,

‎store/postgres/src/relational/dsl.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ impl<'a> Table<'a> {
176176
}
177177

178178
/// Reference a column in this table and use the correct SQL type `ST`
179-
fn bind<ST>(&self, name: &str) -> Option<BoundColumn<ST>> {
179+
fn bind<ST>(&self, name: &str) -> Option<BoundColumn<'_,ST>> {
180180
self.column(name).map(|c| c.bind())
181181
}
182182

‎store/postgres/src/relational_queries.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4964,6 +4964,7 @@ impl<'a, Conn> RunQueryDsl<Conn> for CountCurrentVersionsQuery<'a> {}
49644964
/// Helper struct for returning the id's touched by the RevertRemove and
49654965
/// RevertExtend queries
49664966
#[derive(QueryableByName, PartialEq, Eq, Hash)]
4967+
#[allow(dead_code)]
49674968
pub struct CopyVid {
49684969
#[diesel(sql_type = BigInt)]
49694970
pub vid: i64,

‎store/postgres/src/subgraph_store.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,7 @@ impl SubgraphStoreInner {
789789
/// connections can deadlock the entire process if the pool runs out
790790
/// of connections in between getting the first one and trying to get the
791791
/// second one.
792-
pub(crate) fn primary_conn(&self) -> Result<primary::Connection, StoreError> {
792+
pub(crate) fn primary_conn(&self) -> Result<primary::Connection<'_>, StoreError> {
793793
let conn = self.mirror.primary().get()?;
794794
Ok(primary::Connection::new(conn))
795795
}

‎store/postgres/src/writable.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ use crate::{primary, primary::Site, relational::Layout, SubgraphStore};
4949
struct WritableSubgraphStore(SubgraphStore);
5050

5151
impl WritableSubgraphStore {
52-
fn primary_conn(&self) -> Result<primary::Connection, StoreError> {
52+
fn primary_conn(&self) -> Result<primary::Connection<'_>, StoreError> {
5353
self.0.primary_conn()
5454
}
5555

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /