-
Notifications
You must be signed in to change notification settings - Fork 18.4k
net/http/httputil: remove redundant pw.Close() call in DumpRequestOut #75029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 7c38f9f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/696415.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from 黄志文:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-27T22:31:02Z","revision":"705fe3fa72e598146dbef528685fe5c3ac90e726"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 1: Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 1: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
pw.Close() is already deferred earlier in DumpRequestOut. Change-Id: Icdc9366c816848ed0bb444022d2aa14e4ceaabac GitHub-Last-Rev: 7c38f9f GitHub-Pull-Request: #75029 Reviewed-on: https://go-review.googlesource.com/c/go/+/696415 Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Sean Liao <sean@liao.dev> Auto-Submit: Sean Liao <sean@liao.dev>
Message from Sean Liao:
Patch Set 1: Auto-Submit+1 Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696415.
After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/696415 has been merged.
pw.Close() is already deferred earlier in DumpRequestOut.