Commit f74ed44

1911860538gopherbot

1911860538

authored and

committed

net/http/httputil: remove redundant pw.Close() call in DumpRequestOut

pw.Close() is already deferred earlier in DumpRequestOut. Change-Id: Icdc9366c816848ed0bb444022d2aa14e4ceaabac GitHub-Last-Rev: 7c38f9f GitHub-Pull-Request: #75029 Reviewed-on: https://go-review.googlesource.com/c/go/+/696415 Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Sean Liao <sean@liao.dev> Auto-Submit: Sean Liao <sean@liao.dev>

1 parent a9689d2 commit f74ed44Copy full SHA for f74ed44

File tree

1 file changed

-1

lines changed

src/net/http/httputil
- dump.go

1 file changed

-1

lines changed

`‎src/net/http/httputil/dump.go`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,6 @@ func DumpRequestOut(req *http.Request, body bool) ([]byte, error) {`
`147`	`147`
`148`	`148`	`req.Body = save`
`149`	`149`	`if err != nil {`
`150`		`- pw.Close()`
`151`	`150`	`dr.err = err`
`152`	`151`	`close(quitReadCh)`
`153`	`152`	`return nil, err`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit f74ed44

File tree

1 file changed

1 file changed

`‎src/net/http/httputil/dump.go`

0 commit comments