cmd/cgo: fix unaligned arguments typedmemmove crash on iOS #74868

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Copy link

Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/692935.
After addressing review feedback, remember to publish your drafts!

Copy link

Contributor

Message from Tim Cooijmans:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/692935.
After addressing review feedback, remember to publish your drafts!

Copy link

Contributor

Message from Tim Cooijmans:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/692935.
After addressing review feedback, remember to publish your drafts!


 cmd/cgo: fix unaligned arguments typedmemmove crash on iOS

0dc7484

Irregularly typedmemmove and bulkBarrierPreWrite crashes on unaligned
arguments. By aligning the arguments this is fixed.
Fixes golang#46893

@timcooijmans timcooijmans force-pushed the feature/fix-unaligned-arguments branch from aa1d171 to 0dc7484 Compare

Copy link

Contributor

Message from Cherry Mui:

Patch Set 2: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/692935.
After addressing review feedback, remember to publish your drafts!

Copy link

Contributor

This PR (HEAD: 0dc7484) has been imported to Gerrit for code review.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.