Commit 0dc7484

committed

cmd/cgo: fix unaligned arguments typedmemmove crash on iOS

Irregularly typedmemmove and bulkBarrierPreWrite crashes on unaligned arguments. By aligning the arguments this is fixed. Fixes #46893

1 parent b2960e3 commit 0dc7484Copy full SHA for 0dc7484

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1051,7 +1051,7 @@ func (p *Package) writeExports(fgo2, fm, fgcc, fgcch io.Writer) {`
`1051`	`1051`	`// string.h for memset, and is also robust to C++`
`1052`	`1052`	`// types with constructors. Both GCC and LLVM optimize`
`1053`	`1053`	`// this into just zeroing _cgo_a.`
`1054`		`- fmt.Fprintf(fgcc, "\ttypedef %s %v _cgo_argtype;\n", ctype.String(), p.packedAttribute())`
	`1054`	`+ fmt.Fprintf(fgcc, "\ttypedef %s %v __attribute__((aligned(%d))) _cgo_argtype;\n", ctype.String(), p.packedAttribute(), p.PtrSize)`
`1055`	`1055`	`fmt.Fprintf(fgcc, "\tstatic _cgo_argtype _cgo_zero;\n")`
`1056`	`1056`	`fmt.Fprintf(fgcc, "\t_cgo_argtype _cgo_a = _cgo_zero;\n")`
`1057`	`1057`	`if gccResult != "void" && (len(fntype.Results.List) > 1 \|\| len(fntype.Results.List[0].Names) > 1) {`

Comments

(0)