-
Notifications
You must be signed in to change notification settings - Fork 18.4k
net/http: pool transport gzip readers #61390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: cf5ad00) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
cf5ad00 to
041cc00
Compare
This PR (HEAD: 041cc00) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 1:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Bryan Mills:
Patch Set 2: Code-Review+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Alexander Yastrebov:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Alexander Yastrebov:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Alexander Yastrebov:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Alexander Yastrebov:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
041cc00 to
8349b7d
Compare
This PR (HEAD: 8349b7d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Alexander Yastrebov:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
a632c84 to
607bd71
Compare
This PR (HEAD: 607bd71) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 5:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
607bd71 to
94bcf3e
Compare
Message from Alexander Yastrebov:
Patch Set 5:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 94bcf3e) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 6:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
94bcf3e to
b902028
Compare
This PR (HEAD: b902028) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
b902028 to
8854c57
Compare
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 7:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 8854c57) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Alexander Yastrebov:
Patch Set 7:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: e26eb44) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Alexander Yastrebov:
Patch Set 10:
(9 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 11: Commit-Queue+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 11:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-31T13:53:43Z","revision":"005e3577e782e90f72e3698480ba724ec3c21fd1"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 11: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 11:
This CL has failed the run. Reason:
Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):
- go on master (change 510255) / tools on master (commit ebd6130)
To reproduce, try gomote repro 8705014326094695729.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 11: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 12: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 12:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-31T14:36:44Z","revision":"1697559fbdb3f7f06db36032551cb4a7c3736f20"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 12: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 12:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 12: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
e26eb44 to
5d8d6b3
Compare
This PR (HEAD: 5d8d6b3) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
goos: linux goarch: amd64 pkg: net/http │ HEAD~1 │ HEAD │ │ sec/op │ sec/op vs base │ ClientGzip-8 621.0μ ± 2% 616.3μ ± 10% ~ (p=0.971 n=10) │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │ ClientGzip-8 49.765Ki ± 0% 9.514Ki ± 2% -80.88% (p=0.000 n=10) │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │ ClientGzip-8 57.00 ± 0% 52.00 ± 0% -8.77% (p=0.000 n=10) Allocation saving comes from absent compress/flate.(*dictDecoder).init Updates golang#61353
5d8d6b3 to
e190ff4
Compare
Message from Alexander Yastrebov:
Patch Set 13:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: e190ff4) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/510255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Sean Liao:
Patch Set 14: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 14:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-09-01T17:12:40Z","revision":"e050192fe417959923c018f21913e5fb084af516"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 14: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 14:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
- go on master (change 510255)
To reproduce, try gomote repro 8704911218279571857.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 14: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 14: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 14:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-09-01T18:29:03Z","revision":"e050192fe417959923c018f21913e5fb084af516"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 14: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 14:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 14: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/510255.
After addressing review feedback, remember to publish your drafts!
Uh oh!
There was an error while loading. Please reload this page.
goos: linux
goarch: amd64
pkg: net/http
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
ClientGzip-8 621.0μ ± 2% 616.3μ ± 10% ~ (p=0.971 n=10)
ClientGzip-8 49.765Ki ± 0% 9.514Ki ± 2% -80.88% (p=0.000 n=10)
ClientGzip-8 57.00 ± 0% 52.00 ± 0% -8.77% (p=0.000 n=10)
Allocation saving comes from absent compress/flate.(*dictDecoder).init
Updates #61353