Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

cmd/cgo: enable reproducible builds when LTO is enabled #53528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Foxboron wants to merge 1 commit into golang:master
base: master
Choose a base branch
Loading
from Foxboron:morten/repro-lto

Conversation

Copy link
Contributor

@Foxboron Foxboron commented Jun 24, 2022 •
edited
Loading

The work directory of the compiler is embedded into
compressed sections of the LTO objects. Making them unreproducible between
builds.

The culprit is that the line macros uses bare symbol names, and GCC
prepends each symbol with current directory when compiling.

See See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108534

For each cgo2.c file we parse out the bare symbols in the line macros
and ensure they are rewritten with -fdebug-prefix-map to point at the
absolute directory /tmp.

Reproduction of the issue:

$ CGO_CFLAGS='-flto' go build -work -trimpath -ldflags '-linkmode=external' main.go
WORK=/tmp/go-build2408155205
$ cd /tmp/go-build2408155205/b001
$ objdump -h ./_x002.o | grep GoStringLen
 7 .gnu.lto__GoStringLen.0.6b7d5558e3553715 0000013b 0000000000000000 0000000000000000 0000009c 2**0
$ objcopy ./_x002.o /dev/null --dump-section .gnu.lto__GoStringLen.0.6b7d5558e3553715=GoStringLen.zst
$ unzstd ./GoStringLen.zst
$ strings GoStringLen
/tmp/go-build2408155205/b001

alerque reacted with thumbs up emoji
Copy link
Contributor

This PR (HEAD: 61f4d6e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/413974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Sean Liao:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

This PR (HEAD: 8bab1c8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/413974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Morten Linderud:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Daniel Martí:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 2: Run-TryBot+1 Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

This PR (HEAD: 457c06c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/413974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Morten Linderud:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 3: Run-TryBot+1 Code-Review+2

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

This PR (HEAD: 3abc1b0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/413974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Morten Linderud:

Patch Set 3:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 4: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

This PR (HEAD: dbcf0cb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/413974 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 8: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 9: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 10: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 10: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 10: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 10: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 11: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 11: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Morten Linderud:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Bryan Mills:

Patch Set 12: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Gopher Robot:

Patch Set 13:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/413974.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /