Commit 61f4d6e

committed

cmd/cgo: don't generate random numbers for symbols

If cgo is built with -flto the symbols in runtime/cgo is going to include random numbers which would make builds unreproducible. Settings -frandom-seeds ensures this is consistent across builds. $ strings --all --bytes=8 $WORK/b055/_pkg_.a | grep "gnu.lto_.profile" .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 .gnu.lto_.profile.1 Signed-off-by: Morten Linderud <morten@linderud.pw>

1 parent 2e773a3 commit 61f4d6eCopy full SHA for 61f4d6e

File tree

1 file changed

-0

lines changed

src/cmd/go/internal/work
- exec.go

1 file changed

-0

lines changed

`‎src/cmd/go/internal/work/exec.go`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2551,6 +2551,12 @@ func (b *Builder) compilerCmd(compiler []string, incdir, workdir string) []strin`
`2551`	`2551`	`a = append(a, "-gno-record-gcc-switches")`
`2552`	`2552`	`}`
`2553`	`2553`
	`2554`	`+ // Tell gcc to not insert truly random numbers into the build process`
	`2555`	`+ // this ensures LTO won't create random symbols.`
	`2556`	`+ if b.gccSupportsFlag(compiler, "-frandom-seed=1") {`
	`2557`	`+ a = append(a, "-frandom-seed=1")`
	`2558`	`+ }`
	`2559`	`+`
`2554`	`2560`	`// On OS X, some of the compilers behave as if -fno-common`
`2555`	`2561`	`// is always set, and the Mach-O linker in 6l/8l assumes this.`
`2556`	`2562`	`// See https://golang.org/issue/3253.`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 61f4d6e

File tree

1 file changed

1 file changed

`‎src/cmd/go/internal/work/exec.go`

0 commit comments