Skip to content

correctly handle `uname-cmd` that doesn't point to an executable file #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

EliahKagan merged 16 commits into gitpython-developers:main from gcmarx:main

May 28, 2025

+31 −1

Merged

correctly handle `uname-cmd` that doesn't point to an executable file #2026

Changes from 1 commit

Commits

Show all changes

Select commit Hold shift + click to select a range

add tests for is_cygwin_git

gcmarx May 21, 2025

check for the existence/execute bit on the uname command before tryin...

gcmarx May 21, 2025

adding self to authors

gcmarx May 21, 2025

Revert "check for the existence/execute bit on the uname command befo...

gcmarx May 22, 2025

use pathlib.Path instead of os.path.isfile

gcmarx May 22, 2025

don't keep checking if sys.platform isn't 'cygwin'

gcmarx May 22, 2025

check that uname_cmd points to a file; if uname_cmd were a directory,...

gcmarx May 22, 2025

don't use match-case, since it's a 3.10 feature

gcmarx May 22, 2025

it's is_file(), not isfile()

gcmarx May 22, 2025

turns out f-strings before 3.8 don't support {variable=} notation, ta...

gcmarx May 22, 2025

add self to AUTHORS, add Emacs tempfiles to .gitignore

gcmarx May 23, 2025

use `strings` instead of `uname` to detect cygwin

gcmarx May 27, 2025

gcmarx May 27, 2025

Revert "debug printing"

gcmarx May 28, 2025

Revert "use `strings` instead of `uname` to detect cygwin"

gcmarx May 28, 2025

incorporate review feedback from @EliahKagan

gcmarx May 28, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

Revert "debug printing"

This reverts commit 0df0818.

Loading branch information

gcmarx committed May 28, 2025

commit 58f77105f5163408a9bf323518b96646ab413561

2 changes: 0 additions & 2 deletions git/util.py

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -475,8 +475,6 @@ def _is_cygwin_git(git_executable: str) -> bool:
		process = subprocess.Popen([strings_cmd, git_cmd], stdout=subprocess.PIPE, text=True)
		strings_output, _ = process.communicate()
		is_cygwin = any(x for x in strings_output if "cygwin" in x.lower())
	if not is_cygwin:
	_logger.debug(f"is not cygwin: {strings_output}")
		except Exception as ex:
		_logger.debug("Failed checking if running in CYGWIN due to: %r", ex)
		_is_cygwin_cache[git_executable] = is_cygwin
Expand Down