Skip to content

correctly handle `uname-cmd` that doesn't point to an executable file#2026

Merged

EliahKagan merged 16 commits intogitpython-developers:main from

May 28, 2025

Merged

correctly handle `uname-cmd` that doesn't point to an executable file #2026
EliahKagan merged 16 commits intogitpython-developers:main from
gcmarx:main

Commits

Commits on May 21, 2025

Commits on May 22, 2025

Revert "check for the existence/execute bit on the uname command before trying to run it"
gcmarx gcmarx
committed
use pathlib.Path instead of os.path.isfile
gcmarx gcmarx
committed
don't keep checking if sys.platform isn't 'cygwin'
gcmarx gcmarx
committed
check that uname_cmd points to a file; if uname_cmd were a directory, it could both exist and have os.X_OK but not work
gcmarx gcmarx
committed
don't use match-case, since it's a 3.10 feature
gcmarx gcmarx
committed
it's is_file(), not isfile()
gcmarx gcmarx
committed
turns out f-strings before 3.8 don't support {variable=} notation, take that out
gcmarx gcmarx
committed

Commits on May 27, 2025

Commits on May 28, 2025