This repository was archived by the owner on Sep 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
added validations to every step #50
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,17 @@ steps: | |
| - type: getPullRequest | ||
| pullRequest: Changes | ||
| action_id: metaPR2 | ||
| - type: getFileContents | ||
| action_id: fileContents | ||
| filename: 'src/App.jsx' | ||
| - type: gate | ||
| left: '/^\s*<\s*h3\s*className\s*=\s*"\s*Box-title\s*d-flex\s*flex-justify-center\s*"\s*>\s*GradeBook\s*<\s*\/\s*h3\s*>/gm' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| operator: test | ||
| right: '%actions.fileContents%' | ||
| else: | ||
| - type: respond | ||
| with: bad-header.md | ||
| issue: Changes | ||
| - type: respond | ||
| with: 02-props.md | ||
| issue: Changes | ||
|
|
@@ -74,6 +85,17 @@ steps: | |
| - type: getPullRequest | ||
| pullRequest: Changes | ||
| action_id: metaPR2 | ||
| - type: getFileContents | ||
| action_id: fileContents | ||
| filename: 'src/App.jsx' | ||
| - type: gate | ||
| left: '/^\s*import\s*List\s*from\s*"\s*\.\/List\s*"\s*;\s*/gm' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| operator: test | ||
| right: '%actions.fileContents%' | ||
| else: | ||
| - type: respond | ||
| with: bad-import.md | ||
| issue: Changes | ||
| - type: createPullRequestComment | ||
| body: uncomment-assignments-activity.md | ||
| file: src/App.jsx | ||
|
|
@@ -121,6 +143,17 @@ steps: | |
| - type: getPullRequest | ||
| pullRequest: Changes | ||
| action_id: metaPR2 | ||
| - type: getFileContents | ||
| action_id: fileContents | ||
| filename: 'src/List.jsx' | ||
| - type: gate | ||
| left: '/>\s*{\s*this\.props\.title\s*}\s*<\s*/gm' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one isn't validating for me, https://github.com/hectorsector/intro-react/pull/2#pullrequestreview-276208944. Let's leave that issue open and close the rest when we ship this. |
||
| operator: test | ||
| right: '%actions.fileContents%' | ||
| else: | ||
| - type: respond | ||
| with: bad-prop.md | ||
| issue: Changes | ||
| - type: respond | ||
| with: 03-state.md | ||
| issue: Changes | ||
|
|
@@ -142,6 +175,17 @@ steps: | |
| - type: getPullRequest | ||
| pullRequest: Changes | ||
| action_id: metaPR2 | ||
| - type: getFileContents | ||
| action_id: fileContents | ||
| filename: 'src/App.jsx' | ||
| - type: gate | ||
| left: '/\s*students\s*:\s*\[\s*\]\s*,\s*/gm' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| operator: test | ||
| right: '%actions.fileContents%' | ||
| else: | ||
| - type: respond | ||
| with: bad-state.md | ||
| issue: Changes | ||
| - type: createPullRequestComment | ||
| body: explaining-this-state-activity.md | ||
| file: src/App.jsx | ||
|
|
@@ -231,6 +275,17 @@ steps: | |
| - type: getPullRequest | ||
| pullRequest: Changes | ||
| action_id: metaPR2 | ||
| - type: getFileContents | ||
| action_id: fileContents | ||
| filename: 'src/App.jsx' | ||
| - type: gate | ||
| left: '/\s*placeholder\s*=\s*"Add\sStudent\.\.\."\s*\n\s*currList\s*=\s*{\s*this\.state\.students\s*}\n\s*addFunction\s*=\s*{\s*this\.addStudent\s*}\s*\n/gm' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| operator: test | ||
| right: '%actions.fileContents%' | ||
| else: | ||
| - type: respond | ||
| with: bad-replace.md | ||
| issue: Changes | ||
| - type: createPullRequestComment | ||
| body: uncomment-grades-activity.md | ||
| file: src/App.jsx | ||
|
|
||
2 changes: 1 addition & 1 deletion
responses/bad-function.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| Looks you did not create an `addStudent` function with the parameter: `studentName`. | ||
| Looks like you did not create an `addStudent` function with the parameter: `studentName`. | ||
|
|
||
| Try again! |
3 changes: 3 additions & 0 deletions
responses/bad-header.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Looks like you did not correctly add an `h3` component in the right place in `src/App.jsx`. | ||
|
|
||
| Try again! |
3 changes: 3 additions & 0 deletions
responses/bad-import.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Looks like you did not import the `List` component into `App`. | ||
|
|
||
| Try again! |
3 changes: 3 additions & 0 deletions
responses/bad-prop.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Looks like you did not replace the title with a prop in the correct place in `src/List.jsx` | ||
|
|
||
| Try again! |
3 changes: 3 additions & 0 deletions
responses/bad-replace.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Looks like you did not replace the props for student rendering. | ||
|
|
||
| Try again! |
3 changes: 3 additions & 0 deletions
responses/bad-state.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Looks like you did not add a `students` state variable. | ||
|
|
||
| Try again! |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.