This repository was archived by the owner on Sep 1, 2022. It is now read-only.

added validations to every step#50

Merged

hectorsector merged 6 commits intomaster from

validations

Aug 20, 2019

Merged

added validations to every step #50
hectorsector merged 6 commits intomaster from
validations

Conversation

@partyshah

Copy link

@partyshah partyshah commented Aug 16, 2019 •

edited by hectorsector

Loading

Closes #47
Closes #46
Closes #44
Closes #43


 added validations to every step

9ff7993

@github-learning-lab github-learning-lab bot temporarily deployed to production

August 16, 2019 16:21

Inactive

@github-learning-lab

Copy link

github-learning-lab bot commented Aug 16, 2019

Your draft course version was created!

You can edit it using the Course Builder UI!


 added multiline

a56f634

@github-learning-lab github-learning-lab bot temporarily deployed to production

August 16, 2019 16:38

Inactive


 fixed prop validation

ec18543

@github-learning-lab github-learning-lab bot temporarily deployed to production

August 16, 2019 16:54

Inactive


 add validations

478c310

@github-learning-lab github-learning-lab bot temporarily deployed to production

August 16, 2019 17:23

Inactive


 added correct responses for validations

@github-learning-lab github-learning-lab bot temporarily deployed to production

August 16, 2019 18:23

Inactive


 minor fixes

5745f1d

@github-learning-lab github-learning-lab bot temporarily deployed to production

August 16, 2019 18:39

Inactive

@partyshah

Copy link

Author

partyshah commented Aug 16, 2019

@hectorsector Can I get a review?

I fixed #50

Here is my repo where I tested it: partyshah/intro-react#2

hectorsector

hectorsector approved these changes

Aug 17, 2019

View reviewed changes

Copy link

Contributor

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the note about the one that didn't work. But if we leave that issue open we can 🚢 this.

config.yml

action_id: fileContents

filename: 'src/List.jsx'

- type: gate

left: '/>\s*{\s*this\.props\.title\s*}\s*<\s*/gm'

Copy link

Contributor

@hectorsector hectorsector Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't validating for me, https://github.com/hectorsector/intro-react/pull/2#pullrequestreview-276208944. Let's leave that issue open and close the rest when we ship this.

config.yml

action_id: fileContents

filename: 'src/App.jsx'

- type: gate

left: '/^\s*<\s*h3\s*className\s*=\s*"\s*Box-title\s*d-flex\s*flex-justify-center\s*"\s*>\s*GradeBook\s*<\s*\/\s*h3\s*>/gm'

Copy link

Contributor

@hectorsector hectorsector Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config.yml

action_id: fileContents

filename: 'src/App.jsx'

- type: gate

left: '/^\s*import\s*List\s*from\s*"\s*\.\/List\s*"\s*;\s*/gm'

Copy link

Contributor

@hectorsector hectorsector Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config.yml

action_id: fileContents

filename: 'src/App.jsx'

- type: gate

left: '/\s*students\s*:\s*\[\s*\]\s*,\s*/gm'

Copy link

Contributor

@hectorsector hectorsector Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config.yml

action_id: fileContents

filename: 'src/App.jsx'

- type: gate

left: '/\s*placeholder\s*=\s*"Add\sStudent\.\.\."\s*\n\s*currList\s*=\s*{\s*this\.state\.students\s*}\n\s*addFunction\s*=\s*{\s*this\.addStudent\s*}\s*\n/gm'

Copy link

Contributor

@hectorsector hectorsector Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hectorsector hectorsector merged commit 9d0e527 into master

Aug 20, 2019

@hectorsector hectorsector deleted the validations branch

August 20, 2019 01:31

Labels

None yet

2 participants

@partyshah @hectorsector

Conversation

@partyshah partyshah commented Aug 16, 2019 • edited by hectorsector Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-learning-lab bot commented Aug 16, 2019

Your draft course version was created!

Uh oh!

partyshah commented Aug 16, 2019

Uh oh!

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

Uh oh!

@hectorsector hectorsector Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

@hectorsector hectorsector Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

@hectorsector hectorsector Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

@hectorsector hectorsector Aug 17, 2019

Choose a reason for hiding this comment

Uh oh!

@hectorsector hectorsector Aug 17, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

@partyshah partyshah commented Aug 16, 2019 •

edited by hectorsector

Loading