This repository was archived by the owner on Sep 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
@github-learning-lab
github-learning-lab
bot
temporarily deployed
to
production
August 14, 2019 18:03
Inactive
@github-learning-lab
github-learning-lab
bot
temporarily deployed
to
production
August 14, 2019 18:06
Inactive
@github-learning-lab
github-learning-lab
bot
temporarily deployed
to
production
August 14, 2019 20:53
Inactive
@github-learning-lab
github-learning-lab
bot
temporarily deployed
to
production
August 14, 2019 20:59
Inactive
Author
partyshah
commented
Aug 14, 2019
Alright, I fixed #38 , #40 , and #39 @hectorsector
@github-learning-lab
github-learning-lab
bot
temporarily deployed
to
production
August 14, 2019 22:55
Inactive
@github-learning-lab
github-learning-lab
bot
temporarily deployed
to
production
August 14, 2019 23:16
Inactive
Author
partyshah
commented
Aug 14, 2019
@hectorsector would you be able to take this course?
Contributor
hectorsector
commented
Aug 15, 2019
@partyshah just did! Thanks for the improvements. There are still a number of missing validations, which I've opened issues for. Let's make sure those are taken care of. I'm merging this PR because it improves the experience, but the course isn't complete until we can validate the learner's steps.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.