-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Prepare this repo for OSS
fixed response formats
Your draft course version was created!
You can edit it using the Course Builder UI: https://lab.github.com/githubtraining/introduction-to-react/admin/final-edits/builder
partyshah
commented
Aug 13, 2019
This fixes 38 of the 41 checks in #35 along with fixing other formats.
Currently working on fixing package-lock and template commit messages. I didn't fix the {} because with Prettier formatting for JSX, I am pretty sure comments are supposed to be in {}.
Currently working on fixing
package-lockand template commit messages. I didn't fix the{}because withPrettierformatting for JSX, I am pretty sure comments are supposed to be in{}.
@partyshah 👍 Okay. This may be something to keep an eye out for with the regex hopefully catching if users leave this in, and also if it's a place where people get stuck.
@partyshah Please let me know when the template repo, package-lock, and Cynthia and Hector's feedback is ready to test! 🎉
0d255e0 to
3e47271
Compare
brianamarie
commented
Aug 15, 2019
Hi @partyshah! Can you add some context please about why this pull request is closed? Is the work in another pull request? cc @hectorsector @crichID
partyshah
commented
Aug 15, 2019
@brianamarie I messed up and rewrote the commit history with github teacher as the author. @hectorsector thought it was best to make a separate PR - #37
No description provided.