Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Final edits#36

Closed
partyshah wants to merge 148 commits intomaster from
final-edits
Closed

Final edits #36
partyshah wants to merge 148 commits intomaster from
final-edits

Conversation

@partyshah
Copy link

@partyshah partyshah commented Aug 13, 2019

No description provided.

@github-learning-lab github-learning-lab bot temporarily deployed to production August 13, 2019 21:18 Inactive
Copy link

Your draft course version was created!


You can edit it using the Course Builder UI: https://lab.github.com/githubtraining/introduction-to-react/admin/final-edits/builder

@github-learning-lab github-learning-lab bot temporarily deployed to production August 13, 2019 21:35 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 13, 2019 22:47 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 13, 2019 22:49 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 13, 2019 22:50 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 13, 2019 22:56 Inactive
Copy link
Author

Hi @crichID @brianamarie

This fixes 38 of the 41 checks in #35 along with fixing other formats.

Currently working on fixing package-lock and template commit messages. I didn't fix the {} because with Prettier formatting for JSX, I am pretty sure comments are supposed to be in {}.

Copy link
Contributor

brianamarie commented Aug 14, 2019
edited
Loading

Currently working on fixing package-lock and template commit messages. I didn't fix the {} because with Prettier formatting for JSX, I am pretty sure comments are supposed to be in {}.

@partyshah 👍 Okay. This may be something to keep an eye out for with the regex hopefully catching if users leave this in, and also if it's a place where people get stuck.

@partyshah Please let me know when the template repo, package-lock, and Cynthia and Hector's feedback is ready to test! 🎉

@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 17:13 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 14, 2019 17:31 Inactive
@github-learning-lab github-learning-lab bot had a problem deploying to production August 14, 2019 17:58 Failure
Copy link
Contributor

Hi @partyshah! Can you add some context please about why this pull request is closed? Is the work in another pull request? cc @hectorsector @crichID

Copy link
Author

@brianamarie I messed up and rewrote the commit history with github teacher as the author. @hectorsector thought it was best to make a separate PR - #37

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /