Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(submit): tighten submit output and surface swallowed warnings#1197

Open
jonnii wants to merge 1 commit into
jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase from
jonnii/20260610220955/tighten-submit-output-and-surface-swallowed
Open

fix(submit): tighten submit output and surface swallowed warnings #1197
jonnii wants to merge 1 commit into
jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase from
jonnii/20260610220955/tighten-submit-output-and-surface-swallowed

Conversation

@jonnii

@jonnii jonnii commented Jun 10, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

A full pass over what submit prints, in both TTY and line-by-line modes:

  • Route PR create/update warnings (failed labels, reviewers, assignees)
    through a new BranchWarningEvent. They previously went straight to the
    console, which the runner quiets while the TUI is active, so in
    interactive mode they were silently dropped. The TUI now renders them
    under the progress rows and persists them on exit.
  • Replace CompletionEvent.Success with a typed Outcome (complete,
    up-to-date, dry-run, canceled, nothing-to-submit, failed) so handlers
    stop string-matching "Submit complete". Failure outcomes print nothing
    extra — the returned error already reaches the user — which removes the
    duplicate "Submit failed" line.
  • Rework validation output: the fallen-behind-trunk note is now a warning
    with a remedy; the empty-branch warning block (which listed branches the
    plan re-listed and asked a question it never prompted for) is folded into
    the plan as a dim (empty) annotation, with a real confirm prompt in
    interactive runs; the merged/closed tip now follows the warning instead
    of preceding it.
  • Plan lines show the PR number for updates (branch -> update fix(submit): persist per-branch failures after the submit TUI exits #1189 ), the
    update-only skip reason drops the redundant "skipped," prefix, and
    --confirm states what it will do ("Create 2 and update 1 PRs?").
  • Done lines keep the verb next to the ref ("fix(submit): persist per-branch failures after the submit TUI exits #1189 created"), so an
    unexpected create is visible at a glance. Non-TTY output drops the
    transitional "Creating..." lines; only terminal states print.
  • The persisted TTY summary renders each PR as an OSC 8 hyperlink (one
    clickable line per PR). Non-TTY output keeps raw two-line URLs so logs
    stay greppable. The TUI header no longer round-trips through a global
    message string.

Stack

Auto-generated by Stackit

@jonnii jonnii force-pushed the jonnii/20260610220955/tighten-submit-output-and-surface-swallowed branch from ed56226 to a1ba3c3 Compare June 16, 2026 10:34
@jonnii jonnii changed the base branch from jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase to main June 16, 2026 10:34
@jonnii jonnii changed the base branch from main to jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase June 16, 2026 10:34
@jonnii jonnii force-pushed the jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase branch from 2db29d7 to b733f1b Compare June 17, 2026 01:51
@jonnii jonnii force-pushed the jonnii/20260610220955/tighten-submit-output-and-surface-swallowed branch from a1ba3c3 to 54fb9d2 Compare June 17, 2026 01:51
@jonnii jonnii changed the base branch from jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase to main June 17, 2026 01:51
@jonnii jonnii changed the base branch from main to jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase June 17, 2026 01:51
@jonnii jonnii force-pushed the jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase branch from b733f1b to cd34b01 Compare June 19, 2026 19:28
@jonnii jonnii changed the base branch from jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase to main June 19, 2026 19:28
@jonnii jonnii force-pushed the jonnii/20260610220955/tighten-submit-output-and-surface-swallowed branch from 54fb9d2 to d89d2d3 Compare June 19, 2026 19:28
@jonnii jonnii changed the base branch from main to jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase June 19, 2026 19:28
@jonnii jonnii changed the base branch from jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase to main June 20, 2026 01:11
@jonnii jonnii force-pushed the jonnii/20260610220955/tighten-submit-output-and-surface-swallowed branch from d89d2d3 to 8558de4 Compare June 20, 2026 01:11
@jonnii jonnii force-pushed the jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase branch from cd34b01 to b937736 Compare June 20, 2026 01:11
@jonnii jonnii changed the base branch from main to jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase June 20, 2026 01:11
A full pass over what submit prints, in both TTY and line-by-line modes:
- Route PR create/update warnings (failed labels, reviewers, assignees)
 through a new BranchWarningEvent. They previously went straight to the
 console, which the runner quiets while the TUI is active, so in
 interactive mode they were silently dropped. The TUI now renders them
 under the progress rows and persists them on exit.
- Replace CompletionEvent.Success with a typed Outcome (complete,
 up-to-date, dry-run, canceled, nothing-to-submit, failed) so handlers
 stop string-matching "Submit complete". Failure outcomes print nothing
 extra — the returned error already reaches the user — which removes the
 duplicate "Submit failed" line.
- Rework validation output: the fallen-behind-trunk note is now a warning
 with a remedy; the empty-branch warning block (which listed branches the
 plan re-listed and asked a question it never prompted for) is folded into
 the plan as a dim (empty) annotation, with a real confirm prompt in
 interactive runs; the merged/closed tip now follows the warning instead
 of preceding it.
- Plan lines show the PR number for updates (branch -> update #1189), the
 update-only skip reason drops the redundant "skipped," prefix, and
 --confirm states what it will do ("Create 2 and update 1 PRs?").
- Done lines keep the verb next to the ref ("#1189 created"), so an
 unexpected create is visible at a glance. Non-TTY output drops the
 transitional "Creating..." lines; only terminal states print.
- The persisted TTY summary renders each PR as an OSC 8 hyperlink (one
 clickable line per PR). Non-TTY output keeps raw two-line URLs so logs
 stay greppable. The TUI header no longer round-trips through a global
 message string.
@jonnii jonnii changed the base branch from jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase to main June 23, 2026 02:14
@jonnii jonnii force-pushed the jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase branch from b937736 to 90c1bd0 Compare June 23, 2026 02:14
@jonnii jonnii changed the base branch from main to jonnii/20260610213308/defer-the-submit-TUI-until-the-submission-phase June 23, 2026 02:14
@jonnii jonnii force-pushed the jonnii/20260610220955/tighten-submit-output-and-surface-swallowed branch from 8558de4 to f510aa4 Compare June 23, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /