Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(submit): remove dead stack-tree rendering from submit TUI#1190

Open
jonnii wants to merge 1 commit into
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI from
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
Open

refactor(submit): remove dead stack-tree rendering from submit TUI #1190
jonnii wants to merge 1 commit into
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI from
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI

Conversation

@jonnii

@jonnii jonnii commented Jun 10, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

The compact progress view no longer calls RenderStack, so the tree renderer
path was dead weight: Model.Renderer/RootBranch and the annotation-mutation
block in View, the StartSubmitMsg/SetSequentialMsg messages, URLStyle, and
the handler code that built the renderer (snapshotToStackTree, findRootBranch,
stack/fixedMap fields). SubmissionStartEvent.IsSequential is dropped too —
its only consumer was the dead SetSequentialMsg; the action still submits
new stacks sequentially internally. The storyboard submit stories now match
the compact view, and StackSnapshot stays intact as the action-layer contract.


Stack

Auto-generated by Stackit

@jonnii jonnii force-pushed the jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI branch from 099ea39 to 34d1129 Compare June 10, 2026 21:44
@jonnii jonnii force-pushed the jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI branch from 9fc4392 to 233e395 Compare June 10, 2026 21:44
@jonnii jonnii force-pushed the jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI branch from 233e395 to 6f72475 Compare June 16, 2026 10:34
@jonnii jonnii force-pushed the jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI branch from 34d1129 to 51ab8cf Compare June 16, 2026 10:34
@jonnii jonnii changed the base branch from jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI to main June 17, 2026 01:51
@jonnii jonnii force-pushed the jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI branch from 51ab8cf to 9d730ab Compare June 17, 2026 01:51
@jonnii jonnii changed the base branch from main to jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI June 17, 2026 01:51
@jonnii jonnii changed the base branch from jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI to main June 19, 2026 19:28
@jonnii jonnii force-pushed the jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI branch from 9d730ab to 7423b12 Compare June 19, 2026 19:28
@jonnii jonnii changed the base branch from main to jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI June 19, 2026 19:28
@jonnii jonnii changed the base branch from jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI to main June 20, 2026 01:11
@jonnii jonnii force-pushed the jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI branch from 7423b12 to 679f3b8 Compare June 20, 2026 01:11
@jonnii jonnii changed the base branch from main to jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI June 20, 2026 01:11
The compact progress view no longer calls RenderStack, so the tree renderer
path was dead weight: Model.Renderer/RootBranch and the annotation-mutation
block in View, the StartSubmitMsg/SetSequentialMsg messages, URLStyle, and
the handler code that built the renderer (snapshotToStackTree, findRootBranch,
stack/fixedMap fields). SubmissionStartEvent.IsSequential is dropped too —
its only consumer was the dead SetSequentialMsg; the action still submits
new stacks sequentially internally. The storyboard submit stories now match
the compact view, and StackSnapshot stays intact as the action-layer contract.
@jonnii jonnii changed the base branch from jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI to main June 23, 2026 02:14
@jonnii jonnii force-pushed the jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI branch from 679f3b8 to d542535 Compare June 23, 2026 02:14
@jonnii jonnii changed the base branch from main to jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI June 23, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /