-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(submit): remove dead stack-tree rendering from submit TUI#1190
Open
Conversation
This was referenced Jun 10, 2026
@jonnii
jonnii
force-pushed
the
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
branch
from
June 10, 2026 21:44
099ea39 to
34d1129
Compare
@jonnii
jonnii
force-pushed
the
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
branch
from
June 10, 2026 21:44
9fc4392 to
233e395
Compare
@jonnii
jonnii
force-pushed
the
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
branch
from
June 16, 2026 10:34
233e395 to
6f72475
Compare
@jonnii
jonnii
force-pushed
the
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
branch
from
June 16, 2026 10:34
34d1129 to
51ab8cf
Compare
@jonnii
jonnii
changed the base branch from
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
to
main
June 17, 2026 01:51
@jonnii
jonnii
force-pushed
the
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
branch
from
June 17, 2026 01:51
51ab8cf to
9d730ab
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
June 17, 2026 01:51
@jonnii
jonnii
changed the base branch from
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
to
main
June 19, 2026 19:28
@jonnii
jonnii
force-pushed
the
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
branch
from
June 19, 2026 19:28
9d730ab to
7423b12
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
June 19, 2026 19:28
@jonnii
jonnii
changed the base branch from
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
to
main
June 20, 2026 01:11
@jonnii
jonnii
force-pushed
the
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
branch
from
June 20, 2026 01:11
7423b12 to
679f3b8
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
June 20, 2026 01:11
This was referenced Jun 20, 2026
The compact progress view no longer calls RenderStack, so the tree renderer path was dead weight: Model.Renderer/RootBranch and the annotation-mutation block in View, the StartSubmitMsg/SetSequentialMsg messages, URLStyle, and the handler code that built the renderer (snapshotToStackTree, findRootBranch, stack/fixedMap fields). SubmissionStartEvent.IsSequential is dropped too — its only consumer was the dead SetSequentialMsg; the action still submits new stacks sequentially internally. The storyboard submit stories now match the compact view, and StackSnapshot stays intact as the action-layer contract.
@jonnii
jonnii
changed the base branch from
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
to
main
June 23, 2026 02:14
@jonnii
jonnii
force-pushed
the
jonnii/20260609200349/remove-dead-stack-tree-rendering-from-submit-TUI
branch
from
June 23, 2026 02:14
679f3b8 to
d542535
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260609200006/persist-per-branch-failures-after-the-submit-TUI
June 23, 2026 02:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The compact progress view no longer calls RenderStack, so the tree renderer
path was dead weight: Model.Renderer/RootBranch and the annotation-mutation
block in View, the StartSubmitMsg/SetSequentialMsg messages, URLStyle, and
the handler code that built the renderer (snapshotToStackTree, findRootBranch,
stack/fixedMap fields). SubmissionStartEvent.IsSequential is dropped too —
its only consumer was the dead SetSequentialMsg; the action still submits
new stacks sequentially internally. The storyboard submit stories now match
the compact view, and StackSnapshot stays intact as the action-layer contract.
Stack
Auto-generated by Stackit