Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

ref(node-core): Add mechanism to cron instrumentations #17544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into develop from lms/ref-node-core-cronInstrumentation
Sep 11, 2025

Conversation

Copy link
Member

@Lms24 Lms24 commented Sep 5, 2025 •
edited
Loading

  • ref(node-core): Add mechanism to cron instrumentations
  • adjust tests

ref #17260

seer-by-sentry[bot] reacted with hooray emoji
@Lms24 Lms24 mentioned this pull request Sep 5, 2025
2 tasks
Copy link
Contributor

github-actions bot commented Sep 5, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,231 - 9,109 +1%
GET With Sentry 1,228 13% 1,225 +0%
GET With Sentry (error only) 5,877 64% 5,775 +2%
POST Baseline 1,193 - 1,143 +4%
POST With Sentry 465 39% 451 +3%
POST With Sentry (error only) 1,058 89% 991 +7%
MYSQL Baseline 3,292 - 3,325 -1%
MYSQL With Sentry 416 13% 444 -6%
MYSQL With Sentry (error only) 2,667 81% 2,720 -2%

View base workflow run

@Lms24 Lms24 force-pushed the lms/ref-node-core-cronInstrumentation branch from 4f00a4b to 0c60aa2 Compare September 9, 2025 14:42
@Lms24 Lms24 marked this pull request as ready for review September 11, 2025 13:08
@Lms24 Lms24 requested review from a team, AbhiPrasad, chargome and timfish and removed request for a team and chargome September 11, 2025 13:08
@Lms24 Lms24 self-assigned this Sep 11, 2025
@Lms24 Lms24 merged commit f742746 into develop Sep 11, 2025
377 of 394 checks passed
@Lms24 Lms24 deleted the lms/ref-node-core-cronInstrumentation branch September 11, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /