Commit f742746

authored

ref(node-core): Add mechanism to cron instrumentations (#17544)

- **ref(node-core): Add `mechanism` to cron instrumentations** - **adjust tests** ref #17260

1 parent 15e22cd commit f742746Copy full SHA for f742746

File tree

+45

-6

lines changed

+45

-6

lines changed

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,15 @@ test('cron instrumentation', async () => {`
`69`	`69`	`})`
`70`	`70`	`.expect({`
`71`	`71`	`event: {`
`72`		`- exception: { values: [{ type: 'Error', value: 'Error in cron job' }] },`
	`72`	`+ exception: {`
	`73`	`+ values: [`
	`74`	`+ {`
	`75`	`+ type: 'Error',`
	`76`	`+ value: 'Error in cron job',`
	`77`	`+ mechanism: { type: 'auto.function.cron.instrumentCron', handled: false },`
	`78`	`+ },`
	`79`	`+ ],`
	`80`	`+ },`
`73`	`81`	`},`
`74`	`82`	`})`
`75`	`83`	`.start()`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,15 @@ test('node-cron instrumentation', async () => {`
`69`	`69`	`})`
`70`	`70`	`.expect({`
`71`	`71`	`event: {`
`72`		`- exception: { values: [{ type: 'Error', value: 'Error in cron job' }] },`
	`72`	`+ exception: {`
	`73`	`+ values: [`
	`74`	`+ {`
	`75`	`+ type: 'Error',`
	`76`	`+ value: 'Error in cron job',`
	`77`	`+ mechanism: { type: 'auto.function.node-cron.instrumentNodeCron', handled: false },`
	`78`	`+ },`
	`79`	`+ ],`
	`80`	`+ },`
`73`	`81`	`},`
`74`	`82`	`})`
`75`	`83`	`.start()`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,15 @@ test('node-schedule instrumentation', async () => {`
`69`	`69`	`})`
`70`	`70`	`.expect({`
`71`	`71`	`event: {`
`72`		`- exception: { values: [{ type: 'Error', value: 'Error in cron job' }] },`
	`72`	`+ exception: {`
	`73`	`+ values: [`
	`74`	`+ {`
	`75`	`+ type: 'Error',`
	`76`	`+ value: 'Error in cron job',`
	`77`	`+ mechanism: { type: 'onunhandledrejection', handled: false },`
	`78`	`+ },`
	`79`	`+ ],`
	`80`	`+ },`
`73`	`81`	`},`
`74`	`82`	`})`
`75`	`83`	`.start()`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,12 @@ export function instrumentCron<T>(lib: T & CronJobConstructor, monitorSlug: stri`
`99`	`99`	`try {`
`100`	`100`	`await onTick(context, onComplete);`
`101`	`101`	`} catch (e) {`
`102`		`- captureException(e);`
	`102`	`+ captureException(e, {`
	`103`	`+ mechanism: {`
	`104`	`+ handled: false,`
	`105`	`+ type: 'auto.function.cron.instrumentCron',`
	`106`	`+ },`
	`107`	`+ });`
`103`	`108`	`throw e;`
`104`	`109`	`}`
`105`	`110`	`},`
`@@ -136,7 +141,12 @@ export function instrumentCron<T>(lib: T & CronJobConstructor, monitorSlug: stri`
`136`	`141`	`try {`
`137`	`142`	`await onTick(context, onComplete);`
`138`	`143`	`} catch (e) {`
`139`		`- captureException(e);`
	`144`	`+ captureException(e, {`
	`145`	`+ mechanism: {`
	`146`	`+ handled: false,`
	`147`	`+ type: 'auto.function.cron.instrumentCron',`
	`148`	`+ },`
	`149`	`+ });`
`140`	`150`	`throw e;`
`141`	`151`	`}`
`142`	`152`	`},`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,12 @@ export function instrumentNodeCron<T>(lib: Partial<NodeCron> & T): T {`
`53`	`53`	`try {`
`54`	`54`	`return await callback();`
`55`	`55`	`} catch (e) {`
`56`		`- captureException(e);`
	`56`	`+ captureException(e, {`
	`57`	`+ mechanism: {`
	`58`	`+ handled: false,`
	`59`	`+ type: 'auto.function.node-cron.instrumentNodeCron',`
	`60`	`+ },`
	`61`	`+ });`
`57`	`62`	`throw e;`
`58`	`63`	`}`
`59`	`64`	`},`

Comments

(0)