Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: handle spread #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gajus merged 5 commits into gajus:master from AlbertLucianto:fix/classname-omitted
Mar 21, 2019
Merged

Conversation

Copy link
Contributor

@AlbertLucianto AlbertLucianto commented Mar 21, 2019

Should fix #44

This is done by appending the resulting className with possible className value from spread attributes. Also added some test cases for these changes.

Appreciate for your review!

DimitrK and tyler-dot-earth reacted with hooray emoji tyler-dot-earth reacted with heart emoji giorgosavgeris and tyler-dot-earth reacted with rocket emoji
@gajus gajus merged commit 05c2683 into gajus:master Mar 21, 2019
Copy link
Owner

gajus commented Mar 21, 2019

Very cool!

Copy link
Owner

gajus commented Mar 21, 2019

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

giorgosavgeris reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process className key in a destructured object

AltStyle によって変換されたページ (->オリジナル) /