-
-
Notifications
You must be signed in to change notification settings - Fork 161
fix: spread should not traverse children elements #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDIT: errr, might've had a bug in my own code. Sorry for the noise :( 👎 Thanks again for the work on this feature, it's awesome ❤️
(削除) @AlbertLucianto Wonderful work on #243! I understand the reasoning behind #245 here as well, though it would be nice if children traversal worked in the same file when spreading on children, like such: (削除ここまで)
return (
<div
{...wrapperProps}
styleName="wrapper"
>
<SingleLineInput
{...otherProps}
styleName="input"
/>
<div styleName="icon-wrapper">
<Icon icon="search" />
</div>
</div>
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #244
Sorry for the bug. When traversing the spread attributes, an element traverses spread attributes in children elements as well. This fix simply changes the traversal into a simple loop. I also add a test case for this one.