Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

doc: add documentation on usage of PCI support #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bchalios merged 2 commits into firecracker-microvm:main from bchalios:pci_docs
Aug 26, 2025

Conversation

Copy link
Contributor

@bchalios bchalios commented Aug 25, 2025
edited
Loading

Add information in our Documentation regarding how users can enable PCI support for Firecracker microVMs and mention requirements for building the guest kernel, as well as the requirements for kernel command line parameters.

Also, add an entry in the CHANGELOG mentioning the addition of PCI support.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@bchalios bchalios self-assigned this Aug 25, 2025
@bchalios bchalios added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 25, 2025
@bchalios bchalios enabled auto-merge (rebase) August 25, 2025 15:46
Copy link

codecov bot commented Aug 25, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.17%. Comparing base (4ee4c68) to head (45d5b6c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #5404 +/- ##
==========================================
+ Coverage 83.12% 83.17% +0.04% 
==========================================
 Files 266 266 
 Lines 30527 30533 +6 
==========================================
+ Hits 25377 25397 +20 
+ Misses 5150 5136 -14 
Flag Coverage Δ
5.10-c5n.metal 83.23% <100.00%> (+<0.01%) ⬆️
5.10-m5n.metal 83.23% <100.00%> (+<0.01%) ⬆️
5.10-m6a.metal 82.54% <100.00%> (-0.01%) ⬇️
5.10-m6g.metal 79.87% <100.00%> (+<0.01%) ⬆️
5.10-m6i.metal 83.23% <100.00%> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.53% <100.00%> (?)
5.10-m7g.metal 79.87% <100.00%> (+<0.01%) ⬆️
5.10-m7i.metal-24xl 83.20% <100.00%> (?)
5.10-m7i.metal-48xl 83.20% <100.00%> (?)
5.10-m8g.metal-24xl 79.87% <100.00%> (?)
5.10-m8g.metal-48xl 79.87% <100.00%> (?)
6.1-c5n.metal 83.27% <100.00%> (+<0.01%) ⬆️
6.1-m5n.metal 83.28% <100.00%> (+<0.01%) ⬆️
6.1-m6a.metal 82.59% <100.00%> (+0.01%) ⬆️
6.1-m6g.metal 79.87% <100.00%> (+<0.01%) ⬆️
6.1-m6i.metal 83.27% <100.00%> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.57% <100.00%> (?)
6.1-m7g.metal 79.87% <100.00%> (+<0.01%) ⬆️
6.1-m7i.metal-24xl 83.28% <100.00%> (?)
6.1-m7i.metal-48xl 83.29% <100.00%> (?)
6.1-m8g.metal-24xl 79.87% <100.00%> (?)
6.1-m8g.metal-48xl 79.87% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bchalios bchalios force-pushed the pci_docs branch 3 times, most recently from f530744 to 5840825 Compare August 26, 2025 09:44
Add information in our Documentation regarding how users can enable PCI
support for Firecracker microVMs and mention requirements for building
the guest kernel, as well as the requirements for kernel command line
parameters.
Also, add an entry in the CHANGELOG mentioning the addition of PCI
support.
Signed-off-by: Babis Chalios <bchalios@amazon.es>
We have a single lock for all devices on the PCI bus that serializes
reads and writes on the devices' PCI configuration space and BARs.
This should not be a problem at the moment. It should be out of any hot
path and only up until we are setting up devices. However, add a comment
that mentions the existence of the contention so that we keep it in mind
for the futuer (and maybe perform some profiling).
Signed-off-by: Babis Chalios <bchalios@amazon.es>
@bchalios bchalios merged commit 6169ec3 into firecracker-microvm:main Aug 26, 2025
7 checks passed
@bchalios bchalios deleted the pci_docs branch August 26, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyazin kalyazin kalyazin approved these changes

@ShadowCurse ShadowCurse ShadowCurse approved these changes

@xmarcalx xmarcalx Awaiting requested review from xmarcalx xmarcalx is a code owner

@pb8o pb8o Awaiting requested review from pb8o pb8o is a code owner

@Manciukic Manciukic Awaiting requested review from Manciukic Manciukic is a code owner

Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /