-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 5, 2026
@github-actions
github-actions
Bot
added
the
needs:spec-owner-review
Current knowledge records await owner approval
label
Sep 5, 2026
15 tasks
imdreamrunner
force-pushed
the
agent/harden-lab-drawer-20260904
branch
from
September 5, 2026 06:15
138abe1 to
5e6ef7a
Compare
Contributor
PR Analysis Report
Modified ComponentsLayer (@astryxdesign/core)
Drawer (@astryxdesign/lab)
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual RegressionStatus: No visual change across 2 compared shot(s). Generated by PR Enrichment workflow | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Why
Drawer needs to satisfy the shared overlay and native top-layer contracts while it is still in Lab, before any promotion changes are considered. Keeping this hardening separate makes the behavior review independent from the package move.
What
z-indexladder with the shared layer-dismissal stack.showModal()for modal Drawer and a manual Popover API host for non-modal Drawer, retainingdialog.show()as the reduced fallback for browsers below the Popover API floor.<dialog>closeevent for non-modal consumers afterhidePopover().Drawer remains in
@astryxdesign/labin this PR. There are no Core exports, import migrations, CLI blocks, or promotion changes here.Risk
The behavioral change is limited to Drawer lifecycle and stacking. The public props and root
<dialog>element are unchanged. Non-modal Drawer remains interactive with the page behind it and retains the previouscloseevent contract.Testing
pnpm lint:strictpnpm buildpnpm -F @astryxdesign/core build && pnpm -F @astryxdesign/lab typecheckpnpm storybook:buildpnpm guard:modal-close --storybook-dir apps/storybook/distcloseevent per exitpnpm a11y:audit -- --components Drawer— 8 stories, 0 violationspnpm rtl:audit -- --filter Drawer— D4 pass, no coverage gapA package-filtered
pnpm -F @astryxdesign/lab testis not a valid repo-wide invocation: it changes the process cwd topackages/lab, so root-relative CLI and fixture tests resolve paths beneath that package. The directly relevant suites above pass from the repository root.