-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft
Conversation
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 5, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@github-actions
github-actions
Bot
added
the
needs:design-review
Affects visuals — Design should review
label
Sep 5, 2026
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
September 5, 2026 04:40
@github-actions
github-actions
Bot
added
the
needs:spec-owner-review
Current knowledge records await owner approval
label
Sep 5, 2026
imdreamrunner
force-pushed
the
agent/promote-drawer-core-20260904
branch
from
September 5, 2026 04:59
58e4ce6 to
e14779e
Compare
Contributor
PR Analysis Report
New ComponentsDrawer (@astryxdesign/core)
Modified ComponentsLayer (@astryxdesign/core)
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual RegressionStatus: Skipped — Broad stable scope is deferred to the daily release gate. It covers 380 trusted baseline shots instead of recapturing them for this PR. View the report Generated by PR Enrichment workflow | View full report |
imdreamrunner
force-pushed
the
agent/promote-drawer-core-20260904
branch
from
September 5, 2026 06:04
e14779e to
baf8a0b
Compare
imdreamrunner
changed the base branch from
main
to
agent/harden-lab-drawer-20260904
September 5, 2026 06:04
imdreamrunner
force-pushed
the
agent/promote-drawer-core-20260904
branch
from
September 5, 2026 06:12
baf8a0b to
f55981b
Compare
imdreamrunner
force-pushed
the
agent/harden-lab-drawer-20260904
branch
from
September 5, 2026 06:15
138abe1 to
5e6ef7a
Compare
imdreamrunner
force-pushed
the
agent/promote-drawer-core-20260904
branch
from
September 5, 2026 06:16
f55981b to
8cc08ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Stack
Depends on #6073 — harden Drawer layer lifecycle in Lab. This PR intentionally contains only promotion and migration work; the behavior changes are reviewed first in #6073.
Why
Once the Lab hardening lands, Drawer satisfies the shared overlay and native top-layer contracts required for Core. Promoting it gives consumers a stable inspector/detail-panel primitive without changing its public props.
Prior API work: #3327, #5246. The broader Sheet questions remain in #3675; this promotion stays inline-axis only and continues to direct block-axis use cases to BottomSheet.
What
@astryxdesign/labto@astryxdesign/core/Drawer.astryx upgrade --applycodemod that movesDrawerandDrawerPropsimports/re-exports from the Lab root or Lab Drawer subpath to@astryxdesign/core/Drawer.[breaking]minor release for Core and CLI.Risk
There is no Drawer behavior change relative to #6073. The main compatibility risk is the import-path move; the codemod covers value imports, type imports, aliases, mixed Lab imports, direct Drawer subpaths, and re-exports.
Testing
pnpm lint:strictpnpm buildpnpm check:syncpnpm check:knowledgepnpm check:changesetspnpm check:cli-structurepnpm sync:exports:checkpnpm check:package-boundariespnpm storybook:buildpnpm guard:modal-close --storybook-dir apps/storybook/distpnpm a11y:audit -- --components Drawer— 8 stories, 0 violationspnpm rtl:audit -- --filter Drawer— D4 pass, no coverage gapAccessibility promotion checklist
aria-modalis present only for the modal path; controlledisOpenremains authoritative.prefers-reduced-motion.useTranslator().Before marking ready
main.