-
Notifications
You must be signed in to change notification settings - Fork 22
Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6dc556b
removes devDependency on JSDOM as we not using it! fixes #27
nelsonic 2b87184
UPDATE version of JSDOM to latest (v11) fixes https://github.com/dwyl...
nelsonic 8151426
uncomment Click tests which were not working (upgrading to JSDOM v.11...
nelsonic 95ce302
adds "Contributions Welcome" Badge to readme see: https://github.com/...
nelsonic 89ee37c
remove ignore block from tests to avoid hypocracy! not running the JS...
nelsonic d088d27
adds test assertion comments. fixes #20
nelsonic f4e81bf
adds pre-commit hook to check coverage before allowing commits. see: ...
nelsonic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,20 +6,21 @@ require('qunit-tap')(QUnit, console.log); // use console.log for test output | |
| var jsdom = require("jsdom"); // https://github.com/tmpvar/jsdom | ||
| var { JSDOM } = jsdom; | ||
| var path = require('path'); | ||
| // var html = fs.readFileSync(path.resolve(__dirname, | ||
| // '../examples/counter-reset/index.html')); | ||
| // var DOM = new JSDOM(html); | ||
| var fs = require('fs'); | ||
| var html = fs.readFileSync(path.resolve(__dirname, | ||
| '../examples/counter-reset/index.html')); | ||
| var DOM = new JSDOM(html); | ||
| var id = 'test-app' | ||
| var DOM = new JSDOM(`<!DOCTYPE html><div id="${id}">Hello world</div>`); | ||
| // var DOM = new JSDOM(`<!DOCTYPE html><div id="${id}">Hello world</div>`); | ||
| var document = DOM.window.document; // shortcut to JSDOM document | ||
|
|
||
| test('hello world before mounting app', function(assert){ | ||
| var actual = document.getElementById(id).textContent; // "Hello world" | ||
| var expected = "Hello world"; | ||
| assert.equal(expected, actual); | ||
| test('Mount app expect state to be Zero', function(assert){ | ||
| var actual = document.getElementById(id).textContent; | ||
| var actual_stripped = parseInt(actual.replace('+', '').replace('-Reset', ''), 10); | ||
| var expected = 0; | ||
| assert.equal(expected, actual_stripped, "Inital state set to 0."); | ||
| }); | ||
|
|
||
|
|
||
| var counter = require(path.resolve(__dirname, | ||
| '../examples/counter-reset/counter.js')); | ||
| var { view, mount, update, div, button, empty, init} = counter; | ||
|
|
@@ -41,25 +42,25 @@ btn.addEventListener('click', function() { | |
| console.log('increment button CLICKed!!'); | ||
| var state = document.getElementById(id) | ||
| .getElementsByClassName('count')[0].textContent; | ||
| console.log('state:', state); | ||
| // console.log('state:', state); | ||
| }); | ||
|
|
||
| // btn.dispatchEvent(evt); | ||
|
|
||
|
|
||
| test('Test Update update(0) returns 0 (current state)', function(assert) { | ||
| var result = update(0); | ||
| assert.equal(result, 0); | ||
| assert.equal(result, 0, "Initial state: 0, No Action, Final state: 0"); | ||
| }); | ||
|
|
||
| test('Test Update increment: update(1, "inc") returns 2', function(assert) { | ||
| var result = update(1, "inc"); | ||
| assert.equal(result, 2); | ||
| assert.equal(result, 2, "Initial state: 1, Increment once, Final state: 2"); | ||
| }); | ||
|
|
||
| test('Test Update decrement: update(3, "dec") returns 2', function(assert) { | ||
| var result = update(1, "dec"); | ||
| assert.equal(result, 0); | ||
| assert.equal(result, 0, "Initial state: 1, Decrement once, Final state: 0"); | ||
| }); | ||
|
|
||
|
|
||
|
|
@@ -81,50 +82,54 @@ function(assert) { | |
| var state = document.getElementById(id) | ||
| .getElementsByClassName('count')[0].innerHTML; | ||
| console.log('state:', state); | ||
| assert.equal(state, 8); // model was incremented successfully | ||
| assert.equal(state, 8, | ||
| "End State is 8 after incrementing 7 by 1 (as expected)"); // model was incremented successfully | ||
| done(); | ||
| }); | ||
|
|
||
| btn.dispatchEvent(evt); | ||
| // document.getElementById(id).getElementsByClassName('inc')[0].click(); | ||
| }); | ||
|
|
||
| // test('Click reset button resets state to 0', function(assert) { | ||
| // mount(7, update, view, id); | ||
| // var root = document.getElementById(id); | ||
| // assert.equal(root.getElementsByClassName('count')[0].textContent, 7); | ||
| // var btn = root.getElementsByClassName("reset")[0]; // click reset button | ||
| // btn.click(); // Click the Reset button! | ||
| // var state = root.getElementsByClassName('count')[0].textContent; | ||
| // assert.equal(state, 0); // state was successfully reset to 0! | ||
| // empty(root); // clean up after tests | ||
| // // console.log('STATE:', state); | ||
| // }); | ||
| test('Click reset button resets state to 0', function(assert) { | ||
| mount(7, update, view, id); | ||
| var root = document.getElementById(id); | ||
| assert.equal(root.getElementsByClassName('count')[0].textContent, 7); | ||
| var btn = root.getElementsByClassName("reset")[0]; // click reset button | ||
| btn.click(); // Click the Reset button! | ||
| var state = root.getElementsByClassName('count')[0].textContent; | ||
| assert.equal(state, 0, "State is 0 (Zero) after reset."); // state was successfully reset to 0! | ||
| empty(root); // clean up after tests | ||
| // console.log('STATE:', state); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are a couple of commented out |
||
| }); | ||
|
|
||
| // Reset Functionality | ||
|
|
||
| // test('Test reset counter when model/state is 6 returns 0', function(assert) { | ||
| // var result = update(6, "reset"); | ||
| // assert.equal(result, 0); | ||
| // }); | ||
| // | ||
| test('Test reset counter when model/state is 6 returns 0', function(assert) { | ||
| var result = update(6, "reset"); | ||
| assert.equal(result, 0); | ||
| }); | ||
|
|
||
| // please make this test pass if you know how! thanks! :-) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worth also opening an issue on this 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please feel free to open that issue. thanks. 👍 |
||
| // test('reset button should be present on page', function(assert) { | ||
| // var reset = document.getElementsByClassName('reset'); | ||
| // console.log(reset); | ||
| // assert.equal(reset.length, 1); | ||
| // }); | ||
|
|
||
|
|
||
|
|
||
| // test('Click reset button resets state to 0', function(assert) { | ||
| // mount(7, update, view, id); | ||
| // var root = document.getElementById(id); | ||
| // assert.equal(root.getElementsByClassName('count')[0].textContent, 7); | ||
| // var btn = root.getElementsByClassName("reset")[0]; // click reset button | ||
| // btn.click(); // Click the Reset button! | ||
| // var state = root.getElementsByClassName('count')[0].textContent; | ||
| // assert.equal(state, 0); // state was successfully reset to 0! | ||
| // empty(root); // clean up after tests | ||
| // }); | ||
| test('Click reset button resets state to 0', function(assert) { | ||
| mount(7, update, view, id); | ||
| var root = document.getElementById(id); | ||
| assert.equal(root.getElementsByClassName('count')[0].textContent, 7, | ||
| "initial state is 7 as expected"); | ||
| var btn = root.getElementsByClassName("reset")[0]; // click reset button | ||
| btn.click(); // Click the Reset button! | ||
| var state = root.getElementsByClassName('count')[0].textContent; | ||
| assert.equal(state, 0, | ||
| "State is 0 (Zero) after reset."); // state was successfully reset to 0! | ||
| empty(root); // clean up after tests | ||
| }); | ||
|
|
||
| /* istanbul ignore next */ | ||
| if (typeof module !== 'undefined' && module.exports) { QUnit.load(); } // run the tests | ||
| QUnit.load(); // run the tests | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.