Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iteles merged 7 commits into master from update-jsdom-fixes-click-tests

Jun 11, 2017

Merged

Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

iteles merged 7 commits into master from update-jsdom-fixes-click-tests

Jun 11, 2017

Conversation

nelsonic

Copy link

Member

@nelsonic nelsonic commented Jun 10, 2017

Fixes:

JSDOM Version: Update version of JSDom to avoid out-of-date dependency badge :-| #27
(Server-side) "Click" Tests: Run tests on CLI/CI ? #20

nelsonic added 4 commits

June 10, 2017 20:30

@nelsonic


 removes devDependency on JSDOM as we not using it! fixes  #27

6dc556b

@nelsonic


 UPDATE version of JSDOM to latest (v11) fixes  #27

2b87184

@nelsonic


 uncomment Click tests which were not working (upgrading to JSDOM v.11...

... seems to have fixed them!!!) #20

@nelsonic


 adds "Contributions Welcome" Badge to readme see: https://github.com/...

95ce302

...dwyl/repo-badges

@nelsonic nelsonic added the awaiting-review label

Jun 10, 2017

@nelsonic nelsonic assigned iteles

Jun 10, 2017

@codecov

Copy link

codecov bot commented Jun 10, 2017 •

edited

Loading

Codecov Report

Merging #28 into master will increase coverage by 4.65%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #28 +/- ##
========================================
+ Coverage 95.34% 100% +4.65% 
========================================
 Files 1 1 
 Lines 43 43 
========================================
+ Hits 41 43 +2 
+ Misses 2 0 -2

Impacted Files	Coverage Δ
examples/counter-reset/counter.js	`100% <0%> (+4.65%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2f553...f4e81bf. Read the comment docs.

@nelsonic


 remove ignore block from tests to avoid hypocracy! not running the JS...

89ee37c

...DOM tests on client! #20

@nelsonic

Copy link

Member Author

nelsonic commented Jun 10, 2017

I know I'm a "freak" but the "95% Coverage" Was Bugging me!!
image

image
https://youtu.be/btO3kE2RrEY

@iteles please review/merge when you can. thanks!

nelsonic added 2 commits

June 10, 2017 21:13

@nelsonic


 adds test assertion comments. fixes  #20

d088d27

@nelsonic


 adds pre-commit hook to check coverage before allowing commits. see: h...

f4e81bf

...ttps://github.com/dwyl/learn-pre-commit

@nelsonic

Copy link

Member Author

nelsonic commented Jun 10, 2017

@iteles review/merge not "urgent". but would be nice to get the "Tweet" done on Monday. 😉

iteles

iteles approved these changes

Jun 11, 2017

View reviewed changes

Copy link

Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thanks for getting this ready for the 'big time' @nelsonic 😉

test/test.js

var state = root.getElementsByClassName('count')[0].textContent;

assert.equal(state, 0, "State is 0 (Zero) after reset."); // state was successfully reset to 0!

empty(root); // clean up after tests

// console.log('STATE:', state);

Copy link

Member

@iteles iteles Jun 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of commented out console.logs but I'm happy to leave them in for the time being as these might actually be useful to beginners when we publicise the tutorial #29

test/test.js

assert.equal(result, 0);

});

// please make this test pass if you know how! thanks! :-)

Copy link

Member

@iteles iteles Jun 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth also opening an issue on this 👍

Copy link

Member Author

@nelsonic nelsonic Jun 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please feel free to open that issue. thanks. 👍

@iteles

Copy link

Member

iteles commented Jun 11, 2017

I love how you hearted the codecov comment here 😆

@iteles iteles added in-review and removed awaiting-review labels

Jun 11, 2017

@iteles iteles merged commit d17b772 into master

Jun 11, 2017

@iteles iteles deleted the update-jsdom-fixes-click-tests branch

June 11, 2017 11:10

Labels

in-review

2 participants

@nelsonic @iteles

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

Uh oh!

Conversation

@nelsonic nelsonic commented Jun 10, 2017

Uh oh!

codecov bot commented Jun 10, 2017 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

nelsonic commented Jun 10, 2017

Uh oh!

nelsonic commented Jun 10, 2017

Uh oh!

@iteles iteles left a comment

Choose a reason for hiding this comment

Uh oh!

@iteles iteles Jun 11, 2017

Choose a reason for hiding this comment

Uh oh!

@iteles iteles Jun 11, 2017

Choose a reason for hiding this comment

Uh oh!

@nelsonic nelsonic Jun 11, 2017

Choose a reason for hiding this comment

Uh oh!

iteles commented Jun 11, 2017

Uh oh!

Uh oh!

Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28

Uh oh!

Conversation

@nelsonic nelsonic commented Jun 10, 2017

Uh oh!

codecov bot commented Jun 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nelsonic commented Jun 10, 2017

Uh oh!

nelsonic commented Jun 10, 2017

Uh oh!

@iteles iteles left a comment

Choose a reason for hiding this comment

Uh oh!

@iteles iteles Jun 11, 2017

Choose a reason for hiding this comment

Uh oh!

@iteles iteles Jun 11, 2017

Choose a reason for hiding this comment

Uh oh!

@nelsonic nelsonic Jun 11, 2017

Choose a reason for hiding this comment

Uh oh!

iteles commented Jun 11, 2017

Uh oh!

Uh oh!

codecov bot commented Jun 10, 2017 •

edited

Loading