-
-
Notifications
You must be signed in to change notification settings - Fork 29
Makes classes compatible with mypy 1.2
#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sobolevn just need a little of your help here with the errors!
tests/test_typeclass/test_typed_dict.py:25: error: Invalid metaclass "_Meta" [misc]
This test needs some love.
https://github.com/dry-python/classes/blob/master/tests/test_typeclass/test_typed_dict.py#L9
Right now it is in a semi-broken state.
tests/test_typeclass/test_call.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
Can be just ignored.
This is probably a mypy bug.
You can also report this to mypy.
tests/test_associated_type/test_variadic_generic.py:34: error: Function "Type[Example[Any]]" could always be true in boolean context [truthy-function]
Can be just ignored.
b22e008 to
13d3f44
Compare
Codecov Report
@@ Coverage Diff @@ ## master #487 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 3 +1 Lines 103 106 +3 Branches 18 17 -1 ========================================= + Hits 103 106 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
13d3f44 to
3c1de4f
Compare
I need to dig more deep to see why this expected error is not being raised anymore:
main:29: error: Instance "TypedDict('main.Other', {'name': builtins.str, 'registered': builtins.bool})" does not match inferred type "main.UserDict"
zhukovgreen
commented
Apr 26, 2023
Updated #483 to have also mypy^1.2.0. Can you guys either cherry-pick it here or review after this one is merged
Sure!
You can do the same for returns
zhukovgreen
commented
Apr 26, 2023
Added dry-python/returns#1605
guitvcer
commented
Mar 12, 2025
I need to dig more deep to see why this expected error is not being raised anymore:
main:29: error: Instance "TypedDict('main.Other', {'name': builtins.str, 'registered': builtins.bool})" does not match inferred type "main.UserDict"
Hello. How are things going? If you wish, I can try to fix it.
@guitvcer you are very welcome to create a PR with new mypy version :)
It is rather hard to do, but I can help!
Makes
classescompatible withmypy1.2Checklist
CHANGELOG.md