-
-
Notifications
You must be signed in to change notification settings - Fork 29
Add mypy-plugin extras to allow proper mypy version when using mypy plugin #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhukovgreen
wants to merge
1
commit into
dry-python:master
from
zhukovgreen:fix/ensure-compatible-mypy-version
Open
Add mypy-plugin extras to allow proper mypy version when using mypy plugin #483
zhukovgreen
wants to merge
1
commit into
dry-python:master
from
zhukovgreen:fix/ensure-compatible-mypy-version
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zhukovgreen
zhukovgreen
force-pushed
the
fix/ensure-compatible-mypy-version
branch
from
March 17, 2023 12:41
4050e2a to
322d21b
Compare
@zhukovgreen
zhukovgreen
changed the title
(削除) Pin mypy version to ensure correct work of the mypy plugin (削除ここまで)
(追記) Add mypy-plugin extras to allow proper mypy version when using mypy plugin (追記ここまで)
Mar 17, 2023
@zhukovgreen
zhukovgreen
force-pushed
the
fix/ensure-compatible-mypy-version
branch
from
April 26, 2023 08:57
4fc5b66 to
7c03515
Compare
4 tasks
@zhukovgreen
zhukovgreen
force-pushed
the
fix/ensure-compatible-mypy-version
branch
from
April 26, 2023 16:47
7c03515 to
b73cdf2
Compare
eineruntervielen
commented
Jun 23, 2023
i encountered this problem last night. i adore your library. is their anything still open or why is this issue not merged yet?
all the best, erik
Yes, we need to merge #487 first
@zhukovgreen
zhukovgreen
force-pushed
the
fix/ensure-compatible-mypy-version
branch
from
June 23, 2023 12:14
b73cdf2 to
24ad2e4
Compare
use `pip install classes[mypy-plugin]` for installin additional dependencies required by the mypy-plugin. Add mypy-plugin extra dependency use `pip install classes[mypy-plugin]` for installing additional dependencies required by the mypy-plugin.
@zhukovgreen
zhukovgreen
force-pushed
the
fix/ensure-compatible-mypy-version
branch
from
June 23, 2023 12:18
24ad2e4 to
bc6849f
Compare
eineruntervielen
commented
Jun 25, 2023
thank you for you reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #481
Can be merged after
classescompatible withmypy1.2 #487I have made things!
Checklist
CHANGELOG.mdRelated issues
🙏 Please, if you or your company finds
dry-pythonvaluable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.