Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow example app and tests to be run with Django 2.2 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:dj22-failingtests
May 27, 2019

Conversation

Copy link
Member

@sliverc sliverc commented May 27, 2019

Description of the Change

  • admin app would need several middlewares and other apps configured, hence removed for example app
  • Remove invalid authors references in blogentry.json

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented May 27, 2019
edited
Loading

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #642 +/- ##
=======================================
 Coverage 96.16% 96.16% 
=======================================
 Files 56 56 
 Lines 2866 2866 
=======================================
 Hits 2756 2756 
 Misses 110 110
Impacted Files Coverage Δ
example/settings/dev.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b207f99...5291c2f. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that only Django 2.2 surfaced this.... Perhaps pre-2.2 didn't default a foreign-key integrity check.

LGTM.

@n2ygk n2ygk merged commit f3e67a7 into django-json-api:master May 27, 2019
@sliverc sliverc deleted the dj22-failingtests branch May 27, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /