-
Notifications
You must be signed in to change notification settings - Fork 299
Add missing envlist for Django 2.2 support #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (again:-)
Codecov Report
Merging #641 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #641 +/- ## ======================================= Coverage 96.16% 96.16% ======================================= Files 56 56 Lines 2866 2866 ======================================= Hits 2756 2756 Misses 110 110
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 2109c52...f189ddb. Read the comment docs.
@sliverc weirdness on the home front again. Travis build went just fine but when I do tox -e py37-df20-django22-drf39 all the test_filters fail:
E django.db.utils.IntegrityError: The row in table 'example_entry_authors' with primary key '1' has an invalid foreign key: example_entry_authors.author_id contains a value '1' that does not have a corresponding value in example_author.id.
.tox/py37-df20-django22-drf39/lib/python3.7/site-packages/django/db/backends/sqlite3/base.py:318: IntegrityError
I'm running a full tox now to see if this happens for other versions. So far on older versions there are no complaints. I wonder what other environment/cached thing is causing this...
The blogentry.json has invalid authors referenced. This shouldn't have worked before either... yeah well PR is coming up.
It is properly a difference in sqlite versions (where SQLite Version on Travis is much older). PR #642 fixing this.
Missing change in #640