-
Notifications
You must be signed in to change notification settings - Fork 298
Fix factory boy dependency #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix factory boy dependency #373
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #373 +/- ## =========================================== + Coverage 93% 93.05% +0.05% =========================================== Files 51 51 Lines 2659 2665 +6 =========================================== + Hits 2473 2480 +7 + Misses 186 185 -1
Continue to review full report at Codecov.
|
Thanks @santiavenda2. Would you mind adding a comment with a link to the factory boy issue to the code and/or requirements.txt file so that future developers will be able to know when that dependency limitation can be removed in the future?
Include a link to the GitHub issue so a future dev will know when the dependency can be unpinned.
Nevermind. I took care of adding the comment. Thanks for the fix! 👍
Thanks @mblayman 👍
Factoy Boy 2.9.+ versions are raising this problem when we run the test suite using py.test
ConftestImportFailure: (local('/home/santiago/develop/invgate-django-rest-framework-json-api/example/tests/conftest.py'), (<type 'exceptions.AttributeError'>, AttributeError("'DjangoOptions' object has no attribute 'postgen_declarations'",), <traceback object at 0x7fb1c6b123b0>))
Related issue pytest-dev/pytest-factoryboy#47
To fix this problem temporally we can switch to FactoryBoy 2.8.1.