-
Notifications
You must be signed in to change notification settings - Fork 299
Allow type field on none polymorphic serializers #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sliverc
sliverc
force-pushed
the
type_field_name
branch
from
October 11, 2017 13:18
299f99a to
6a1cbe6
Compare
(削除) For CI to run integrated #373 (削除ここまで) updated to current develop branch.
@sliverc
sliverc
force-pushed
the
type_field_name
branch
from
October 12, 2017 07:27
6a1cbe6 to
f4aab7f
Compare
Codecov Report
@@ Coverage Diff @@ ## develop #376 +/- ## =========================================== + Coverage 93.05% 93.07% +0.01% =========================================== Files 51 52 +1 Lines 2665 2686 +21 =========================================== + Hits 2480 2500 +20 - Misses 185 186 +1
Continue to review full report at Codecov.
|
Closed
@sliverc, thanks for going through all that extra effort for a relatively small change. 👍
sliverc
added a commit
to sliverc/django-rest-framework-json-api
that referenced
this pull request
Oct 10, 2021
This support was added in django-json-api#376 but only for non polymorphic fields. However as per specification [0] `type` must not be a field name and therefore must be forbidden in DJA as well. Some dependents might depend on being allowed to have a field name `type` so deprecating it now and remove it in next major version. [0] https://jsonapi.org/format/#document-resource-object-fields
5 tasks
sliverc
added a commit
to sliverc/django-rest-framework-json-api
that referenced
this pull request
Oct 10, 2021
This support was added in django-json-api#376 but only for non polymorphic fields. However as per specification [0] `type` must not be a field name and therefore must be forbidden in DJA as well. Some dependents might depend on being allowed to have a field name `type` so deprecating it now and remove it in next major version. [0] https://jsonapi.org/format/#document-resource-object-fields
n2ygk
pushed a commit
that referenced
this pull request
Oct 11, 2021
This support was added in #376 but only for non polymorphic fields. However as per specification [0] `type` must not be a field name and therefore must be forbidden in DJA as well. Some dependents might depend on being allowed to have a field name `type` so deprecating it now and remove it in next major version. [0] https://jsonapi.org/format/#document-resource-object-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #211 caused serializers with type field to fail, breaking backwards compatibility. This change fixes this by allowing type fields again on none polymorphic serializers.