Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PHP-239 - PHP 8 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qkdreyer wants to merge 7 commits into datastax:master
base: master
Choose a base branch
Loading
from qkdreyer:master
Open

PHP-239 - PHP 8 #147

qkdreyer wants to merge 7 commits into datastax:master from qkdreyer:master

Conversation

Copy link

@qkdreyer qkdreyer commented Jan 5, 2022
edited
Loading

@qkdreyer qkdreyer changed the title (削除) PHP 8 Compatibility with PreparedStatements (削除ここまで) (追記) PHP-239 - PHP 8 (追記ここまで) Jan 5, 2022
@qkdreyer qkdreyer force-pushed the master branch 23 times, most recently from 44f4db3 to c84ddd3 Compare January 9, 2022 08:10
@qkdreyer qkdreyer force-pushed the master branch 15 times, most recently from b11167c to 48ee3a9 Compare January 10, 2022 08:14
Copy link
Author

Copy link
Author

Copy link
Contributor

adutra commented Jan 17, 2022

@absurdfarce would be the right one to look into this.

Copy link

CharlemagneLasse commented Oct 20, 2022
edited
Loading

With these changes, I get following error when trying to access a row on 8.1:

Uncaught Error: Cannot use object of type Cassandra\\Rows as array

The code is as simple as:

 $res = $session->execute("select * from foobar where key='value'");
 if (!$res->valid())
 return null;
 $row = $res[0]; // error happens here

Worked fine with PHP 7.4 and the original datastax cassandra driver. So ArrayAccess seems to be broken here.

qkdreyer reacted with confused emoji

Copy link
Author

I can reproduce... sadly this was not unit tested 😞

Copy link

What is missing exactly? I'm studying about Cassandra and ScyllaDB, since my main lang is PHP it was about to help me a lot on my studies...

Copy link

@qkdreyer how can I get in touch with you? I saw your PHP 8.1 implementations and I'm wondering if there's any chance to use it for a demo.

qkdreyer reacted with thumbs up emoji

Copy link

Could you update pecl for php 8.x please?

Copy link

I think that its impossible for now since the holders of pecl is from DataStax.

Copy link

Kabingeran commented Mar 12, 2023
edited
Loading

@danielhe4rt Whose repository is this?

Copy link

Is was a fork from he4rt/ScyllaDB

Copy link

Ping me at discord or twitter!

danielhe4rt#0001
@danielhe4rtless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /