Commit abd5ff0

committed

chore: add @sandvige code review

1 parent f6349d2 commit abd5ff0Copy full SHA for abd5ff0

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ WORKDIR /tmp/cassandra-php-driver`
`3`	`3`
`4`	`4`	`RUN apt update -y \`
`5`	`5`	`&& apt install python3 pip cmake unzip mlocate build-essential git libuv1-dev libssl-dev libgmp-dev openssl zlib1g-dev libpcre3-dev openjdk-11-jre openjdk-11-jdk -y \`
`6`		`- && pip install git+git://github.com/riptano/ccm.git@master`
	`6`	`+ && pip install git+https://github.com/riptano/ccm.git@master`
`7`	`7`
`8`	`8`	`COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/local/bin`
`9`	`9`	`RUN docker-php-source extract \`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ This driver works exclusively with the Cassandra Query Language v3 (CQL3) and`
`43`	`43`	`Cassandra's native protocol. The current version works with:`
`44`	`44`
`45`	`45`	`* Apache Cassandra versions 2.1, 2.2 and 3.0+`
`46`		`-* PHP 5.6, PHP 7.0, and PHP 7.1`
	`46`	`+* PHP 5.6, PHP 7.0, PHP 7.1 and PHP 8.1`
`47`	`47`	`* 32-bit (x86) and 64-bit (x64)`
`48`	`48`	`* Thread safe (TS) and non-thread safe (NTS)`
`49`	`49`	`* Compilers: GCC 4.1.2+, Clang 3.4+, and MSVC 2010/2012/2013/2015`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -202,6 +202,8 @@ protected function verifyValue($tableName, $type, $key, $value) {`
`202`	`202`	`if (isset($row['value'])) {`
`203`	`203`	`if ($value instanceof \Countable) {`
`204`	`204`	`$this->assertEquals(count($row['value']), count($value));`
	`205`	`+ } else {`
	`206`	`+ $this->assertEquals($row['value'], $value);`
`205`	`207`	`}`
`206`	`208`	`if (is_object($row['value'])) {`
`207`	`209`	`$this->assertEquals($row['value']->type(), $type);`

Comments

(0)