Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: avoid slicing header if not long enough #3862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knocte wants to merge 1 commit into conventional-changelog:master
base: master
Choose a base branch
Loading
from knocte:amendSlice

Conversation

Copy link
Contributor

@knocte knocte commented Jan 20, 2024 •
edited
Loading

Recent PR[1] didn't take in account very small subjects in subject-full-stop rule.

[1] #3839

escapedcat reacted with rocket emoji 
Recent PR[1] didn't take in account very small subjects in
subject-full-stop rule.
[1] conventional-changelog#3839
@knocte knocte changed the title (削除) fix: avoid slicing input if not long enough (削除ここまで) (追記) fix: avoid slicing header if not long enough (追記ここまで) Jan 20, 2024
Copy link
Member

Should this be tested?

Copy link
Contributor Author

knocte commented Jan 27, 2024

Interestingly enough, I added a test for a short subject (2 characters) and it didn't fail! So I guess "12".slice(-3) might return empty string instead of throwing an exception?
escapedcat reacted with confused emoji

Copy link
Member

Also needs a rebase :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /