Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit f1b374a

Browse files
committed
fix: avoid slicing input if not long enough
Recent PR[1] didn't take in account very small subjects. [1] #3839
1 parent d0be172 commit f1b374a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

β€Ž@commitlint/rules/src/subject-full-stop.tsβ€Ž

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ export const subjectFullStop: SyncRule<string> = (
1515

1616
const negated = when === 'never';
1717
let hasStop = input[input.length - 1] === value;
18-
if (input.slice(-3) === '...') {
18+
let ellipsis = '...';
19+
if (input.length > ellipsis.length && input.slice(-ellipsis.length) === ellipsis) {
1920
hasStop = false;
2021
}
2122

0 commit comments

Comments
(0)

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /