-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix: set shell to False if running subprocess on Windows #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1124 +/- ## ========================================== + Coverage 97.33% 97.58% +0.24% ========================================== Files 42 55 +13 Lines 2104 2486 +382 ========================================== + Hits 2048 2426 +378 - Misses 56 60 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
Looks like CI is failing on windows. We might need to take a deeper look
@Lee-W
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
May 20, 2024
AdrianDC
added a commit
to AdrianDC/commitizen
that referenced
this pull request
Aug 22, 2024
Issue: commitizen-tools#1117, commitizen-tools#1118, commitizen-tools#1124 --- Signed-off-by: Adrian DC <radian.dc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
When running a subprocess through
runincmd.py, if the OS is Windows setshell=False.Closes #1118 and #1117
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Running
rye run cz bumpon a Windows machine in a rye-managed project now works.