[outdated] fix: set shell to False if running subprocess on Windows #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

my1e5 wants to merge 1 commit into commitizen-tools:master from my1e5:fix-shell-windows

Closed

[outdated] fix: set shell to False if running subprocess on Windows #1121

my1e5 wants to merge 1 commit into commitizen-tools:master from my1e5:fix-shell-windows

Conversation

my1e5

Copy link

@my1e5 my1e5 commented May 17, 2024

Description

When running a subprocess through run in cmd.py, if the OS is Windows set shell=False.

Closes #1118

Checklist

Add test cases to all the changes you introduce
Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
Test the changes on the local machine manually
Update the documentation for the changes

Expected behavior

Running rye run cz bump on a Windows machine in a rye-managed project now works.

@my1e5


 fix: set shell to False if running subprocess on Windows

5c1505f

@my1e5 my1e5 requested review from woile, Lee-W and noirbizarre as code owners

May 17, 2024 12:28

@github-actions github-actions bot added the pr-status: wait-for-review label

May 17, 2024

@my1e5 my1e5 closed this

May 17, 2024

@Lee-W

Copy link

Member

Lee-W commented May 19, 2024

May I know why we close this? has the issue been resolved?

@my1e5 my1e5 changed the title ~~(削除) fix: set shell to False if running subprocess on Windows (削除ここまで)~~ (追記) [outdated] fix: set shell to False if running subprocess on Windows (追記ここまで)

May 20, 2024

@my1e5

Copy link

Author