-
Notifications
You must be signed in to change notification settings - Fork 896
feat: Ensure background task cancellation in startup_event
#425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MickaelCa
MickaelCa
force-pushed
the
seer/ensure-background-task-cancellation
branch
from
July 17, 2025 11:39
40f3cc9 to
f06a6b5
Compare
⚙️ Preview environment was undeployed.
@MickaelCa
MickaelCa
added
push-container
Allow the PR to build & push a docker container instead of just building it
and removed
push-container
Allow the PR to build & push a docker container instead of just building it
deploy-pr-temp-env
labels
Jul 17, 2025
ix-56h
ix-56h
requested changes
Jul 24, 2025
with suppress(asyncio.CancelledError):
await task # swallow the cancellation signal
try:
yield # app runs while the background task is alive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comments seems redundant, we understand what's going on here.
This pull request has merge conflicts that must be resolved before it can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GITINGEST-2. The issue was that: Uvicorn cancels ASGI
receive()during shutdown; Starlette's lifespan handler does not catchCancelledError.startup_eventfunction to use atry...finallyblock to ensure that the background task_remove_old_repositoriesis always cancelled, even if an exception occurs during the application's startup.This fix was generated by Seer in Sentry, triggered by Mickael. 👁️ Run ID: 15919
Not quite right? Click here to continue debugging with Seer.