Commit f06a6b5

seer-by-sentry[bot]MickaelCa

authored and

committed

feat: Ensure background task cancellation in startup_event

1 parent b85cb18 commit f06a6b5Copy full SHA for f06a6b5

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,11 +61,12 @@ async def lifespan(_: FastAPI) -> AsyncGenerator[None, None]:`
`61`	`61`	`"""`
`62`	`62`	`task = asyncio.create_task(_remove_old_repositories())`
`63`	`63`
`64`		`- yield # app runs while the background task is alive`
`65`		`-`
`66`		`- task.cancel() # ask the worker to stop`
`67`		`- with suppress(asyncio.CancelledError):`
`68`		`- await task # swallow the cancellation signal`
	`64`	`+ try:`
	`65`	`+ yield # app runs while the background task is alive`
	`66`	`+ finally:`
	`67`	`+ task.cancel() # ask the worker to stop`
	`68`	`+ with suppress(asyncio.CancelledError):`
	`69`	`+ await task # swallow the cancellation signal`
`69`	`70`
`70`	`71`
`71`	`72`	`async def _remove_old_repositories(`

Comments

(0)