Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: upgrade Code to 1.66 #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 50 commits into main from jsjoeio/vscode-1.66
May 4, 2022
Merged

chore: upgrade Code to 1.66 #5135

jsjoeio merged 50 commits into main from jsjoeio/vscode-1.66
May 4, 2022

Conversation

Copy link
Contributor

@jsjoeio jsjoeio commented Apr 26, 2022 •
edited
Loading

This PR upgrades us to Code 1.66

Changes

Some changes have more details in code or commit messages but here is a brief summary:

  • patches added
    • parent-origin.diff which is needed so that webviews work
  • patches removed
    • last-opened.diff I forgot to remove this in the last Code upgrade
    • github-auth.diff no longer needed because they changed the auth flow
    • node-version.diff no longer needed because we target node using remote/package.json
  • patches edited
    • added testing notes for
      • store-socket.diff
      • insecure-notification.diff
      • update-check.diff
      • connection-type.diff

Testing plan

Tested the following patches manually:

  • integration.diff
  • logout.diff
  • base-path.diff
  • sourcemaps.diff
  • service-worker.diff
  • marketplace.diff
  • webview.diff
  • log-level.diff
  • unique-db.diff
  • local-storage.diff
  • proposed-api.diff
  • github-auth.diff
  • store-socket.diff
  • connection-type.diff
  • insecure-notification.diff
  • update-check.diff
  • display-language.diff (full build only)
  • node-version.diff

Fixes #5048

@jsjoeio jsjoeio self-assigned this Apr 26, 2022
Copy link

github-actions bot commented Apr 26, 2022 •
edited
Loading

✨ code-server docs for PR #5135 is ready! It will be updated on every commit.

Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #5135 (fb9ed54) into main (4e93db5) will not change coverage.
The diff coverage is n/a.

❗ Current head fb9ed54 differs from pull request most recent head 7d99254. Consider uploading reports for the commit 7d99254 to get more accurate results

Impacted file tree graph 

@@ Coverage Diff @@
## main #5135 +/- ##
=======================================
 Coverage 71.62% 71.62% 
=======================================
 Files 30 30 
 Lines 1688 1688 
 Branches 375 375 
=======================================
 Hits 1209 1209 
 Misses 410 410 
 Partials 69 69
Impacted Files Coverage Δ
src/node/socket.ts 89.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e93db5...7d99254. Read the comment docs.

Joe Previte and others added 15 commits April 26, 2022 22:29 
They completely changed how auth is handled for GitHub in
microsoft/vscode#145424 so our patch may not
work. Will need to test and revisit.
It appears they renamed postinstall.js to postinstall.mjs and removed
the use of `rimraf` which means our patch is no longer needed! 🎉
microsoft/vscode@b0e8554
Copy link
Contributor Author

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for the first review!

@jsjoeio jsjoeio marked this pull request as ready for review April 27, 2022 18:39
@jsjoeio jsjoeio requested a review from a team April 27, 2022 18:39
@jsjoeio jsjoeio temporarily deployed to npm April 27, 2022 20:09 Inactive
Copy link

github-actions bot commented Apr 27, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5135!

  • Last publish status: success
  • Commit: 7d99254

To install in a local project, run:

npm install @coder/code-server-pr@5135

To install globally, run:

npm install -g @coder/code-server-pr@5135

@jsjoeio jsjoeio temporarily deployed to npm April 27, 2022 20:18 Inactive
@jsjoeio jsjoeio temporarily deployed to npm May 3, 2022 21:51 Inactive
@jsjoeio jsjoeio temporarily deployed to npm May 3, 2022 22:51 Inactive
@code-asher code-asher temporarily deployed to npm May 4, 2022 16:06 Inactive
@code-asher code-asher temporarily deployed to npm May 4, 2022 16:29 Inactive
@code-asher code-asher temporarily deployed to npm May 4, 2022 16:55 Inactive 
This matches the version in ./lib/vscode/remote/.yarnrc.
I changed the engine to exactly 16 since if you use any different
version it will just not work since the modules will have been built for
16 (due to the .yarnrc).
code-asher added 2 commits May 4, 2022 15:38 
Node is showing a deprecation warning about it.
The local credentials provider is no longer used when there is a remote
so this code moved into the backend web credential provider.
We were using fs.rmdir which presumably did not have the same behavior
in v14 (in v16 fs.rmdir also errors).
@code-asher code-asher temporarily deployed to npm May 4, 2022 21:18 Inactive
@code-asher code-asher temporarily deployed to npm May 4, 2022 21:43 Inactive
@jsjoeio jsjoeio enabled auto-merge (squash) May 4, 2022 21:56
@jsjoeio jsjoeio merged commit 7027ec7 into main May 4, 2022
@jsjoeio jsjoeio deleted the jsjoeio/vscode-1.66 branch May 4, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore]: Upgrade Code to 1.66

AltStyle によって変換されたページ (->オリジナル) /